Skip to content

docs(estree/tokens): correct comment #19873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 1, 2026
Merged

docs(estree/tokens): correct comment #19873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/oxc_estree_tokens/src/json/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ impl<O: ESTreeTokenConfig, S: SequenceSerializer> Context for JsonContext<'_, O,
/// Inherited from config.
type JSXState = O::JSXState;

/// Returns `true` if serializing in JS style.
/// Returns `true` if serializing in TS style.
#[expect(clippy::inline_always)]
#[inline(always)]
fn is_ts(&self) -> bool {
Expand Down Expand Up @@ -343,8 +343,8 @@ impl<O: ESTreeTokenConfig, S: SequenceSerializer> Context for JsonContext<'_, O,

// `name` is from AST, has escapes decoded by the parser, and is JSON-safe.
// Use it in most cases — if token is not marked as escaped, it's JSON-safe, so can skip JSON encoding.
// When `self.options.decode_identifier_escapes` is `true`, token `value` should *always* be
// the unescaped version, so can also use `name` from AST node and skip JSON encoding.
// When `self.is_js()` is `true`, token `value` should *always* be the unescaped version,
// so can also use `name` from AST node and skip JSON encoding.
// Only fall back to raw source text when the token contains escapes *and* decoding is disabled,
// since escape sequences contain `\` which needs JSON escaping.
// Escaped identifiers are extremely rare, so handle them in `#[cold]` branch.
Expand Down
Loading