build: fix windows auto deploy script

[alandtse]

Modern Windows refuses to execute .cmd files from the current working
directory unless they're prefixed with .\ (introduced as a security
default to prevent CWD command-hijacking). CMake's add_custom_command
strips the absolute path from COMMAND args that live inside
CMAKE_BINARY_DIR (the custom-build CWD), so the generated MSBuild
command was just call robocopy_wrapper.cmd ... - which fails with
"is not recognized as an internal or external command".

Fix: invoke through cmd /c "<absolute-path>". Because the wrapper
path is now an argument to cmd rather than the COMMAND itself, CMake
preserves the absolute path verbatim and the generated MSBuild rule
becomes cmd /c E:\path\to\robocopy_wrapper.cmd ... - which works.

The variable rename (ROBOCOPY_WRAPPER -> ROBOCOPY_WRAPPER_PATH for the
file path, ROBOCOPY_WRAPPER for the invocation list) keeps the three
existing call sites untouched - they consume ${ROBOCOPY_WRAPPER} as
a command-list expansion and pick up the new cmd /c <path> prefix
automatically.

Verified end-to-end with BuildRelease.bat ALL-WITH-AUTO-DEPLOYMENT:
both Skyrim VR and Skyrim Special Edition Data dirs receive the
plugin DLL + shaders without errors.

Summary by CodeRabbit

• Chores

  • Improved Windows deployment handling for more reliable incremental builds.
  • Optimized package preparation to separate shader assets from general files and avoid concurrent writes.
  • Ensured archive creation waits for shader packaging to complete for consistent ZIP outputs.

• Bug Fixes

  • Prevented race conditions during staging by tightening ordering of copy and archive steps.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c86765b8-9e14-4f92-889d-a46765825ac5

📥 Commits

Reviewing files that changed from the base of the PR and between c8ca33e and 83f47ff.

📒 Files selected for processing (1)

• CMakeLists.txt

🚧 Files skipped from review as they are similar to previous changes (1)

• CMakeLists.txt

---

📝 Walkthrough

Walkthrough

CMake changes: Windows robocopy wrapper is invoked via cmd /c "<absolute-path>". AIO preparation and staging now exclude Shaders/ (and Tests/ for package inputs) from general copies, delegate shader copying to copy_shaders.stamp, and require that stamp before the AIO archive rebuilds.

Changes

AIO Shader Exclusion and Robocopy Invocation

Layer / File(s)	Summary
Windows Robocopy Wrapper Execution CMakeLists.txt	Robocopy wrapper script invocation on Windows changed to run the generated absolute wrapper via cmd /c "<absolute-path>", storing the absolute path in ROBOCOPY_WRAPPER_PATH and setting ROBOCOPY_WRAPPER.
AIO Input Exclusion CMakeLists.txt	Package globs (package/*) filtered to exclude /Tests/ and /Shaders/; per-feature input globs filtered to exclude /Shaders/ for change-tracking.
AIO Staging Copy Logic CMakeLists.txt	Staging copy refactored to copy filtered package source files (no Tests/Shaders) and non-shader files per feature folder; shader copying remains handled by copy_shaders.stamp.
AIO Archive Dependency CMakeLists.txt	AIO archive custom command now depends on both PREPARE_AIO and copy_shaders.stamp before rebuilding the ZIP.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• community-shaders/skyrim-community-shaders#1603: Related changes to shader-copying behavior and shader destination layout in CMakeLists.
• community-shaders/skyrim-community-shaders#1372: Related PREPARE_AIO / copy_shaders stamp-based packaging workflow changes.
• community-shaders/skyrim-community-shaders#2251: Modifies AIO incremental deployment/CMake logic touching PREPARE_AIO and copy_shaders stamp targets.

Suggested reviewers

• doodlum
• SkrubbySkrubInAShrub

Poem

🐰 I stitched the build with careful care,
moved Shaders out to keep things fair,
robocopy hides inside a cmd song,
staging hums along, no files go wrong,
hop, deploy — the archive tags along ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'build: fix windows auto deploy script' is partially related to the changeset. It correctly identifies the main fix (Windows auto-deploy), but doesn't capture that the changes also address shader file handling in the AIO system and archive dependency management.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CMakeLists.txt`:
- Around line 427-440: The current change excludes "Shaders/" from the
_AIO_PACKAGE_FILES and from the per-feature _tmp glob, which breaks the
dependency chain (prepare_aio.stamp no longer updates on shader changes) and can
produce stale AIO zips; restore shader staging by either including "Shaders/" in
the package file lists or by explicitly adding the copy_shaders stamp as a
dependency of prepare_aio.stamp/AIO_ZIP targets. Update the CMake logic around
_AIO_PACKAGE_FILES and the FEATURE_PATHS loop (the file(GLOB_RECURSE ...) and
list(FILTER ... EXCLUDE REGEX "/Shaders/") lines) to stop excluding "/Shaders/"
or add a custom add_dependencies(prepare_aio.copy_shaders_target
copy_shaders.stamp) / add_dependencies(AIO_ZIP_PACKAGE prepare_aio_target) so
that copy_shaders.stamp is always considered when building AIO_ZIP_PACKAGE.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 45ffc61f-d6c2-4f2d-976b-347994b976a8

📥 Commits

Reviewing files that changed from the base of the PR and between 58d53e3 and c8ca33e.

📒 Files selected for processing (1)

• CMakeLists.txt

[github-actions]

✅ A pre-release build is available for this PR:
Download