fix(ui): perf overlay interactability corrected when menu closed

[soda3000]

Summary by CodeRabbit

• Style
  • Tables no longer display with horizontal and vertical scrollbars, adjusting layout presentation.

[coderabbitai]

Walkthrough

A single function in the UI utilities file was modified to remove horizontal and vertical scrolling flags from an ImGui table configuration. The ShowSortedStringTableCustom function now creates tables without explicit ScrollX and ScrollY flags, altering the default scrolling behavior while preserving other table properties like borders, row backgrounds, sorting, and resizing capabilities.

Changes

Cohort / File(s)	Summary
UI table flag adjustment src/Utils/UI.h	Removed ImGuiTableFlags_ScrollX and ImGuiTableFlags_ScrollY from the ImGuiTableFlags variable in ShowSortedStringTableCustom, disabling explicit horizontal and vertical scrolling for the table

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Single-line logical change removing two flag constants from a table initialization
• Localized to one function with minimal surface area
• Straightforward flag removal with clear semantic impact

Possibly related PRs

• fix(perf-overlay): removed ImGuiTableFlags_ScrollX/Y for scroll bar issues #1594: Removes ImGuiTableFlags_ScrollX/Y in both ShowSortedStringTableCustom and ShowInteractiveTable functions, directly overlapping with this change.
• fix(perf-overlay): fix infinite draw calls table height #1590: Addresses table scrolling behavior in the same ShowSortedStringTableCustom function but via an alternative approach using outer size parameters and explicit sizing instead of flag removal.
• refactor(perf-overlay): remove collapsible headers #1572: Replaces ShowSortedStringTableCustom usages with a new table-driven approach, potentially superseding or coordinating with this flag adjustment.

Suggested reviewers

• alandtse
• davo0411

Poem

🐰 Scroll flags disappear like morning dew,
ImGui tables streamlined, fresh and new,
ScrollX and ScrollY take their final bow,
Cleaner tables for the present now! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references 'perf overlay interactability' but the changeset only modifies table scrolling flags in UI.h, with no evidence of performance overlay or interactability fixes.	Update the title to accurately reflect the actual change, such as 'fix(ui): remove scroll flags from sorted table' or similar description of the table flag modification.
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 268de33 and 5188903.

📒 Files selected for processing (1)

• src/Utils/UI.h (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Utils/UI.h

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Utils/UI.h

🧠 Learnings (1)

📓 Common learnings

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (1)

src/Utils/UI.h (1)

392-392: No action needed—the change is correct and intentional.

The verification shows this is not an inconsistency. ShowSortedStringTableCustom and ShowInteractiveTable are distinct functions serving different purposes:

• ShowSortedStringTableCustom (line 392): Simple sorted table without scroll flags. Used for performance overlay metrics and wrapped in BeginChild with outer scrolling. Removing scroll flags fixes the interactability issue.
• ShowInteractiveTable (line 977): Advanced table with filtering, custom events, and input handling. Used for shader selection UI where scroll flags are appropriate for its use case.

The scroll flag removal is targeted specifically for the performance overlay bug fix and does not need to apply to the separate ShowInteractiveTable function.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[soda3000]

related issue #1593

[github-actions]

Using provided base ref: 268de33
Using base ref: 268de33
Base commit date: 2025-11-06T14:39:17+10:00 (Thursday, November 06, 2025 02:39 PM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download