Skip to content

fix(ui): add constraints for discord banner size #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlum merged 5 commits into from
Sep 21, 2025
Merged

fix(ui): add constraints for discord banner size #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44f474a
banner max size
davo0411 Sep 10, 2025
ad8c0e8
style: 🎨 apply pre-commit.ci formatting
pre-commit-ci[bot] Sep 10, 2025
582eb79
Update HomePageRenderer.h
davo0411 Sep 21, 2025
ba36ad0
Update src/Menu/HomePageRenderer.cpp
doodlum Sep 21, 2025
e313049
Merge branch 'dev' into discord-banner-size-fix
doodlum Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Menu/HomePageRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,18 @@ void HomePageRenderer::RenderWelcomeSection()
}

if (discordIconAvailable) {
ImVec2 iconSize = ImVec2(menu->uiIcons.discord.size.x, menu->uiIcons.discord.size.y);
// Calculate scaled icon size based on window width, with min/max constraints
ImVec2 originalSize = ImVec2(menu->uiIcons.discord.size.x, menu->uiIcons.discord.size.y);

// Compute width based on window size with constraints and padding (handles very small windows)
float ratioWidth = windowSize.x * DISCORD_BANNER_TARGET_WIDTH_RATIO;
float aspectRatio = originalSize.y / originalSize.x;
float maxAllowed = std::max(1.0f, windowSize.x - DISCORD_BANNER_PADDING_MARGIN);
float upperBound = std::min(DISCORD_BANNER_MAX_WIDTH, maxAllowed);
float lowerBound = std::min(DISCORD_BANNER_MIN_WIDTH, upperBound);
float targetWidth = std::clamp(ratioWidth, lowerBound, upperBound);

ImVec2 iconSize = ImVec2(targetWidth, targetWidth * aspectRatio);
ImGui::SetCursorPosX((windowSize.x - iconSize.x) * 0.5f);

// Push style to remove border
Expand Down
6 changes: 6 additions & 0 deletions src/Menu/HomePageRenderer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ class HomePageRenderer
static constexpr float QUICK_LINKS_BUTTON_WIDTH = 180.0f;
static constexpr float LOGO_WATERMARK_HEIGHT = 260.0f;

// Discord banner scaling constants
static constexpr float DISCORD_BANNER_TARGET_WIDTH_RATIO = 0.85f; // 25% of window width
static constexpr float DISCORD_BANNER_MIN_WIDTH = 150.0f;
static constexpr float DISCORD_BANNER_MAX_WIDTH = 1200.0f;
static constexpr float DISCORD_BANNER_PADDING_MARGIN = 40.0f;

static void RenderHomePage();

// First-time setup management
Expand Down