Allow importing multiple ssh keys when configuring users

[mchf]

Problem

Currently we allow to import only one ssh key for root user. We are asked to be able to 1) import multiple keys for root 2) as well for common user

• jsc#PED-15434

Solution

• intoduced sshPublicKeys profile / config attribute which accepts list of public keys
• in case of root original sshPublicKey attribute is kept for backward compatibility. Internally sshPublicKey and sshPublicKeys are merged together
• change in web UI was not requested for now

[imobachgs]

This PR does not implement exactly what we agreed on. We expected to:

• Extend the existing sshPublicKey attribute to support a single string or an array of strings.
• Add an alias sshPublicKeys.

[mchf]

So I've reverted the commit which changed ssh_public_keys to Vec and deleted "s" ... so now it is ssh_public_key: Option<Vec> again ... I've also modified the code to reflect change in name which was not caught during refactoring

[imobachgs]

Sorry, but I think we do not understand each other. Please, use them Option<StringOrList> in both cases. That's why I said "Please, be consistent" in my comment. The following comment was to make it clear that I did a mistake when I "quoted" the code.

[mchf]

Sorry, but I think we do not understand each other. Please, use them Option<StringOrList> in both cases. That's why I said "Please, be consistent" in my comment. The following comment was to make it clear that I did a mistake when I "quoted" the code.

we definitely don't understand each other. Bcs i did exactly so on frriday (Option<Vec<StringOrList>> for first user and root includin alias ssh_public_keys for both) ... here #3274 (comment) was something what looked as you wanted Option<Vec<String>> for first user, so I asked for confirmation #3274 (comment).

So to summarize that mess:

root's one:

#serde[alias=ssh_public_keys]
ssh_public_key: Option<Vec<StringOrList>>

user's one

#serde[alias=ssh_public_keys]
ssh_public_key:Option<Vec<StringOrList>>

Right?

[imobachgs]

So to summarize that mess:

root's one: #serde[alias=ssh_public_keys] ssh_public_key: Option

user's one #serde[alias=ssh_public_keys] ssh_public_key:Option

Right?

No, in my comment I was just stating that the code in the PR was different for the root user and the first user. If you check #3274 (review) you can see I mentioned it was not consistent. Then I copied the current code, and I made a mistake in the second excerpt that I kind of corrected in #3274 (comment).

And, in the last review, I think it was definitely clear. Quoting from that comment:

Please, use them Option in both cases.

[imobachgs]

Now the code looks good, please fix the conflict and we are done :-)

[mchf]

No, in my comment I was just stating that the code in the PR was different for the root user and the first user. If you check #3274 (review) you can see I mentioned it was not consistent. Then I copied the current code, and I made a mistake in the second excerpt that I kind of corrected in #3274 (comment).

And, in the last review, I think it was definitely clear. Quoting from that comment:

Please, use them Option in both cases.

So some sort of misunderstanding. It happens. Nevermind

Now the code looks good, please fix the conflict and we are done :-)

this looks promising ;-) Conflict is gone ... so I'll do enough restarts in checks to make everything green and it should be done. Thanks for patience