Add hardware information to the API

[imobachgs]

Problem

The current API does not include any hardware information of the underlying system. It might be useful to present this information to the end user.

Solution

Include some basic hardware information as part of the /system object.

{
  "cpu": "AMD Ryzen 5 PRO 5650U with Radeon Graphics",
  "memory": 4294967296,
  "model": "QEMU pc-q35-9.2"
}

Although in the Rust ecosystem there are interesting libraries, like hardware_query, we decided to leverage lshw because it is the same library we use when processing jsonnet profiles.

Testing

• Added a new unit test
• Tested manually

[dgdavid]

LGTM, although I hardly can tell you how fine the implementation is in Rust world 😉

[dgdavid]

missing oxford comma?

[imobachgs]

Not using the Oxford comma at all. I think you and me are the only ones who use it :-)

[dgdavid]

Good!

Excuse me, I forgot that it was an already discussed topic. I guess old habits just kicked in!

👉 https://documentation.suse.com/style/current/single-html/style-guide-db/index.html#sec-comma

[jreidinger]

again, here I think will be useful to either include its output ( which would be sadly quite big ) or content of serde Error which I hope can bring a bit of light to it

[jreidinger]

I would write units here

[dgdavid]

Better to transform to the units you prefer at client side. Or maybe you refer to the comment "Memory size, in bytes"

[jreidinger]

yeap, I am referring to comment

[jreidinger]

in general any usage of ix or ux should mention units unless it is very obvious.

[imobachgs]

Actually, I see that the output of the lshw is like this:

{
  "id" : "memory",
  "class" : "memory",
  "claimed" : true,
  "description" : "Memoria de sistema",
  "physid" : "0",
  "units" : "bytes",
  "size" : 16106127360
},

So I guess we might need something slightly different (e.g., Size(u64, String)) or using a proper type.

[jreidinger]

probably yes, as on system with huge memory like few TB it can cause issue to even fit into type.

[imobachgs]

I have documented it by now, as it only uses bytes according to lshw sources.