Identify whether a pattern was selected by the user

[imobachgs]

Problem

The software proposal does not include information about whether a pattern was selected by the user or by the installer itself.

{
  "software": {
    "size": "3944742 KiB",
    "patterns": {
      "kde": "None",
      "multimedia": "Auto",
      "apparmor": "None",
      "basic_desktop": "None",
      "gnome": "Auto",
      "xfce": "None",
      "selinux": "Auto",
      "office": "Auto",
      "yast2_basis": "None",
      "yast2_desktop": "None",
      "yast2_server": "None"
    }
}

Additionally, there are other problems:

• Capitalization looks wrong.
• The "size" field is already formatted, whether it should be up to the client.
• The proposal is not updated when using the set resolvables API.

Solution

• Distinguish installer (auto) from user-selected (user) patterns and use camelCase.
• Return the size as a number (in KiB).

{
  "size": 6240723,
  "patterns": {
    "basic_desktop": "none",
    "office": "auto",
    "apparmor": "none",
    "kde": "none",
    "yast2_server": "none",
    "yast2_basis": "auto",
    "yast2_desktop": "none",
    "multimedia": "auto",
    "selinux": "none",
    "xfce": "none",
    "gnome": "user"
  }
}

Other changes

The Model struct takes care of talking to libzypp. However, it relies on ZyppServer for communicating with libzypp, which runs on a dedicated thread. As part of this PR, we as simplified ZyppServer API a bit and, instead of implementing smaller actions (like getting the patterns metadata), it now returns SystemInfo and Proposal structs.

Last but not least, now the software proposal is recalculated when using the new set resolvables API.

[jreidinger]

I think we will need in future also the one from kernel cmdline....also is somehow handled that new property @lslezak say about adding it as insecure if additional kernel param is added?

[imobachgs]

I am not sure. It is a different kind of repository and I think it is not signed.

[jreidinger]

this can be quite fragile as unix dir is not url encoded. I worry that it will have problems sooner or later.

[imobachgs]

Can you be more specific, please?

[jreidinger]

well, here you construct url by just appending unix path after "dir:"...so any e.g. space like " " will kill it as it needs to be url encoded to "%20". What I mean here, is that we should sanitize or convert dir into url compatible string.

[imobachgs]

I tend to agree, but in this case I would say the URLs are under our control.

[jreidinger]

It is, but as said in future if we extend it, it can fail. So at least document it in method documentation as note for anyone who would like to re-use method.

[imobachgs]

I am still not convinced of introducing a dependency just for this, but let's unblock the situation. I decided to go with url because it is in the dependencies tree anyway (through zypp-agama).