Centralize logic to decide which components must be rendered at storage/ProposalPage

[ancorgs]

Problem

There is a hook called useConfigIssues that is controversial (see for example #2902 (comment)). And, to be honest, ideally it should not be needed.

The point is that the storage section may have a slightly different format (set of components) depending on quite specific logic. And that hook exists to support that, but...

Why do we need a hook that is used in several parts of the application just because the storage page can have different formats? Because sadly the logic is spread along several components and files.

Solution

Centralize in a single <ProposalPageContent> component all decision making about which components will be rendered and about which issues will be listed. Now it is SO MUCH easier to follow the logic and to know what is going to be rendered.

That allowed us to kill the useConfigIssues hook, now it's logic is used only once. No need to replicate the same criteria in several different places.

Bonus: fixed an eslint-related comment that was leftover from some previous pull request (not sure when the comment became obsolete, but it raised a warning for me).

Testing

All the following combinations were tested manually and the result was the expected one. This should be converted into a unit test at some point.

• Config is ok and supported by UI. Proposal worked. => ModelSection + ProposalResultSection
• Config is ok and supported by UI. Proposal failed. => ProposalFailedInfo + ModelSection + ProposalResultSection
• Config is ok but not supported by UI. Proposal worked. => UnsupportedModelInfo + ProposalResultSection
• Config is ok but not supported by UI. Proposal failed. => UnknownConfigEmptyState
• Config is wrong, supported by UI and fixable. No proposal tried. => FixableConfigInfo + ModelSection
• Config is wrong, supported by UI but not fixable. No proposal tried. => InvalidConfigEmptyState
• Config is wrong and not supported by UI. No proposal tried. => InvalidConfigEmptyState

[joseivanlopez]

LGTM