Add support for files/scripts by imobachgs · Pull Request #2912 · agama-project/agama

imobachgs · 2025-11-26T14:52:25Z

This PR adds support for scripts/files to the new HTTP API. The support for files and classes is included in the new agama-files package which reuses the old internal logic. For that reason. We can improve the internals later.

Additionally, it introduces other related changes:

Extract agama_lib::utils::transfer to a separate package (agama-transfer).
Drop the old scripts and files HTTP APIs.
Add a test_utils module for agama-software.

Follow-up

Fix a reference to /mnt in the ScriptsRunner. I decided to do this in a separate PR and take the chance to add progress and error reporting.

coveralls · 2025-11-26T15:10:13Z

coverage: 61.98%. remained the same
when pulling 1edcd93 on files-service
into cce962e on api-v2.

* Drop the client and the store.

* Drop the store and the client.

* Retry when the "Text file busy" (error 26) happens. * Use std::tokio::process to prevent blocking the thread for long-running scripts.

jreidinger · 2025-11-27T09:53:25Z

rust/agama-autoinstall/src/scripts.rs

    /// It saves the stdout, stderr and exit code to separate files.
    ///
+    /// If the script cannot be execute due to the error "Text file busy (os error 26)",
+    /// wait for 50 milliseconds and try again (up to 5 times).


well, as exact sleep waiting is internal details of run_with_retry and also retry count. I would probably not specify here and just mention that it use run_with_retry where it will be documented.

jreidinger · 2025-11-27T09:54:45Z

rust/agama-autoinstall/src/scripts.rs

        self.save_script(url, &path).await?;

-        let output = std::process::Command::new(&path).output()?;
+        let command = tokio::process::Command::new(&path);


should we change all std::Commands to tokio::Command due to async nature?

Yes, definitely. I will check them in a separate PR.

rust/agama-autoinstall/src/scripts.rs

rust/agama-files/src/service.rs

Merge the new HTTP API. Each PR has been already reviewed, so it should be safe to merge it. * #1829 * #2508 * #2772 * #2826 * #2848 * #2860 * #2863 * #2866 * #2867 * #2869 * #2870 * #2871 * #2872 * #2873 * #2874 * #2875 * #2876 * #2877 * #2880 * #2881 * #2882 * #2884 * #2885 * #2886 * #2891 * #2892 * #2893 * #2894 * #2895 * #2896 * #2897 * #2898 * #2899 * #2900 * #2901 * #2902 * #2903 * #2904 * #2908 * #2909 * #2910 * #2912 * #2913 * #2914 * #2915 * #2916 * #2917 * #2918 * #2920 * #2921 * #2923 * #2924 * #2926 * #2928 * #2929 * #2930 * #2933 * #2934 * #2935 * #2936 * #2938 * #2939 * #2942 * #2943 * #2944 * #2945 * #2946 * #2947 * #2948 * #2950 * #2951 * #2952 * #2954 * #2955 * #2956 * #2957 * #2958 * #2959 * #2960 * #2961 * #2963 * #2964 * #2965 * #2967 * #2968 * #2969 * #2970 * #2971 * #2972 * #2974 * #2975 * #2977 * #2978 * #2980 * #2982 * #2983 * #2984 * #2988 * #2989 * #2991 * #2992 * #2993 * #2994 * #2995 * #2996 * #2997 * #2999

Prepare to release version 19. * #1829 * #2508 * #2772 * #2818 * #2826 * #2848 * #2860 * #2863 * #2864 * #2866 * #2867 * #2869 * #2870 * #2871 * #2872 * #2873 * #2874 * #2875 * #2876 * #2877 * #2880 * #2881 * #2882 * #2884 * #2885 * #2886 * #2891 * #2892 * #2893 * #2894 * #2895 * #2896 * #2897 * #2898 * #2899 * #2900 * #2901 * #2902 * #2903 * #2904 * #2908 * #2909 * #2910 * #2912 * #2913 * #2914 * #2915 * #2916 * #2917 * #2918 * #2920 * #2921 * #2923 * #2924 * #2926 * #2928 * #2929 * #2930 * #2933 * #2934 * #2935 * #2936 * #2937 * #2938 * #2939 * #2942 * #2943 * #2944 * #2945 * #2946 * #2947 * #2948 * #2949 * #2950 * #2951 * #2952 * #2954 * #2955 * #2956 * #2957 * #2958 * #2959 * #2960 * #2961 * #2963 * #2964 * #2965 * #2967 * #2968 * #2969 * #2970 * #2971 * #2972 * #2974 * #2975 * #2977 * #2978 * #2980 * #2981 * #2982 * #2983 * #2984 * #2988 * #2989 * #2990 * #2991 * #2992 * #2993 * #2994 * #2995 * #2996 * #2997 * #2998 * #2999 * #3000 * #3001 * #3002 * #3004 * #3005 * #3006 * #3007 * #3008 * #3009 * #3011 * #3012 * #3013 * #3014 * #3015 * #3016 * #3018 * #3019 * #3020 * #3021 * #3022 * #3023 * #3024 * #3025 * #3026 * #3027 * #3028 * #3029 * #3030 * #3031 * #3033 * #3034 * #3035 * #3036 * #3037 * #3039 * #3040 * #3041 * #3042 * #3043 * #3044 * #3045 * #3046 * #3047 * #3048 * #3049 * #3050 * #3051 * #3052 * #3053 * #3054 * #3055 * #3056 * #3057 * #3058 * #3060 * #3061 * #3062 * #3063 * #3064 * #3065 * #3066 * #3067 * #3068 * #3069 * #3070 * #3071 * #3072 * #3073 * #3074 * #3075 * #3076 * #3077 * #3078 * #3079 * #3086 * #3087 * #3088 * #3089 * #3090 * #3091 * #3092 * #3093 * #3094 * #3095 * #3096 * #3097 * #3098 * #3099 * #3100 * #3101 * #3102 * #3103 * #3104 * #3105 * #3106 * #3107 * #3108 * #3109 * #3110 * #3112 * #3113 * #3114 * #3115 * #3116 * #3117 * #3118 * #3119 * #3120 * #3122 * #3123 * #3124 * #3127 * #3128 * #3129 * #3130 * #3131 * #3133 * #3134 * #3135 * #3136 * #3137 * #3138 * #3139 * #3140 * #3141 * #3142 * #3143 * #3144 * #3145 * #3146 * #3147 * #3148 * #3149 * #3150 * #3151 * #3152 * #3153 * #3154 * #3155 * #3157 * #3158 * #3159 * #3160 * #3161 * #3162 * #3163 * #3164 * #3165 * #3166 * #3167 * #3168 * #3169 * #3170 * #3174 * #3175 * #3176 * #3177 * #3178 * #3179 * #3181 * #3182 * #3184 * #3185 * #3186 * #3188 * #3189 * #3190 * #3191 * #3192 * #3194 * #3195 * #3196 * #3197 * #3198 * #3199 * #3200 * #3201 * #3202 * #3203 * #3205 * #3206 * #3208 * #3209 * #3210 * #3213 * #3214 * #3215 * #3216 * #3217 * #3218 * #3219 * #3220 * #3222 * #3223 * #3224 * #3225 * #3226 * #3227 * #3228 * #3229 * #3230 * #3231 * #3232 * #3233 * #3234 * #3235 * #3236 * #3237 * #3238 * #3239 * #3240 * #3241 * #3242 * #3243 * #3244 * #3246 * #3247 * #3248 * #3250 * #3251 * #3252 * #3253 * #3254 * #3255 * #3256 * #3257 * #3258 * #3259 * #3260 * #3261 * #3262 * #3263 * #3265 * #3266 * #3267 * #3268 * #3269 * #3270 * #3271 * #3272 * #3273 * #3274 * #3275 * #3276 * #3277 * #3278 * #3279 * #3280 * #3281 * #3282 * #3283 * #3284 * #3285 * #3286 * #3287 * #3288 * #3289 * #3290 * #3291

imobachgs force-pushed the files-service branch from 532ff6d to 1edcd93 Compare November 26, 2025 15:03

imobachgs force-pushed the files-service branch 10 times, most recently from d698349 to 15e8428 Compare November 27, 2025 09:34

imobachgs added 15 commits November 27, 2025 09:46

Drop files and scripts HTTP API

af3ce63

Extract agama_lib::utils::transfer to a separate package

c609dec

Rename TransferError to Error

279eb20

agama-utils depends on agama-transfer

96f4a67

Move from agama_lib::files to agama-utils

e317d3a

* Drop the client and the store.

Move agama_lib::scripts to agama-utils

0583d0a

* Drop the store and the client.

Drop files and scripts from InstallSettings

e77e9c2

Drop OpenAPI documentation of the old scripts API

d048fad

Add a test_utils module for agama-software

0784d32

Add a new agama-files package

ac2fa82

Implement the files service

1751123

Use the new files service

369757f

Use a dummy software service during tests

fc13ee9

Add more debugging

8e1785a

Make running more reliable

cc00fea

* Retry when the "Text file busy" (error 26) happens. * Use std::tokio::process to prevent blocking the thread for long-running scripts.

imobachgs marked this pull request as ready for review November 27, 2025 09:47

imobachgs force-pushed the files-service branch from 15e8428 to cc00fea Compare November 27, 2025 09:47

jreidinger reviewed Nov 27, 2025

View reviewed changes

rust/agama-autoinstall/src/scripts.rs Outdated Show resolved Hide resolved

jreidinger reviewed Nov 27, 2025

View reviewed changes

rust/agama-autoinstall/src/scripts.rs Show resolved Hide resolved

jreidinger reviewed Nov 27, 2025

View reviewed changes

rust/agama-files/src/service.rs Show resolved Hide resolved

Update from code review

e9b240d

jreidinger approved these changes Nov 27, 2025

View reviewed changes

Drop unneeded call to Vec::clear

2da33b9

imobachgs merged commit 5ef3200 into api-v2 Nov 27, 2025
14 checks passed

imobachgs deleted the files-service branch November 27, 2025 11:58

imobachgs restored the files-service branch November 28, 2025 11:07

imobachgs mentioned this pull request Jan 9, 2026

Merge the new HTTP API into master #2998

Merged

imobachgs deleted the files-service branch March 3, 2026 06:21

imobachgs mentioned this pull request Mar 17, 2026

Release version 19 #3292

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for files/scripts#2912

Add support for files/scripts#2912
imobachgs merged 17 commits intoapi-v2from
files-service

imobachgs commented Nov 26, 2025 •

edited

Loading

Uh oh!

coveralls commented Nov 26, 2025

Uh oh!

jreidinger Nov 27, 2025

Uh oh!

jreidinger Nov 27, 2025

Uh oh!

imobachgs Nov 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

imobachgs commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Follow-up

Uh oh!

coveralls commented Nov 26, 2025

Uh oh!

jreidinger Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

jreidinger Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

imobachgs Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

imobachgs commented Nov 26, 2025 •

edited

Loading