Skip to content

Fixed sshPublicKey note in autoyast_compat.json#3293

Merged
mchf merged 4 commits intomasterfrom
sshPublicKey_doc_autoyast_compat
Mar 17, 2026
Merged

Fixed sshPublicKey note in autoyast_compat.json#3293
mchf merged 4 commits intomasterfrom
sshPublicKey_doc_autoyast_compat

Conversation

@mchf
Copy link
Copy Markdown
Contributor

@mchf mchf commented Mar 17, 2026

@mchf mchf requested a review from imobachgs March 17, 2026 14:35
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the code and I found out a bug :-)

Please, check:

https://github.com/agama-project/agama/blob/master/service/lib/agama/autoyast/root_reader.rb#L74-L75

Actually, it does not make sense. We should always convert to sshPublicKeys (or sshPublicKey) only.

@imobachgs
Copy link
Copy Markdown
Contributor

@mchf mchf requested a review from imobachgs March 17, 2026 14:41
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add an entry to the changes file regarding the fix when importer the root password.

@mchf mchf force-pushed the sshPublicKey_doc_autoyast_compat branch from 235c09d to c8cf3f2 Compare March 17, 2026 14:52
@mchf mchf requested a review from imobachgs March 17, 2026 14:53
@mchf mchf merged commit bf61284 into master Mar 17, 2026
16 checks passed
@mchf mchf deleted the sshPublicKey_doc_autoyast_compat branch March 17, 2026 16:09
@imobachgs imobachgs mentioned this pull request Mar 24, 2026
imobachgs added a commit that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants