Use the attributes-based D-Bus API to prevent storage deadlocks by imobachgs · Pull Request #3220 · agama-project/agama

imobachgs · 2026-02-27T15:54:20Z

This is the Rust part of Use D-Bus attributes instead of methods #3217.

Problem

bsc#1258466

Solution

To be improved.

Introduce a new agama-storage-client which handles the interaction with the D-Bus service.
It uses zbus proxies to read the configuration, system, proposal, etc. at any time without deadlocks.
It runs the SetConfig in a separate tasks, so it is able to answer other calls.

* Use a proxy to access D-Bus properties. * Run SetConfig on a separate Tokio task.

This reverts commit 35b7558.

rust/agama-bootloader/src/client.rs

rust/agama-storage-client/src/service.rs

rust/agama-utils/src/lib.rs

joseivanlopez · 2026-03-03T09:12:41Z

rust/agama-manager/src/tasks/runner.rs

                        config.storage.clone(),
                    ))
                    .await?;
+                let _ = future.await;


Maybe it should raise the future error, if any.

rust/agama-storage/src/monitor.rs

Prepare to release version 19. * #1829 * #2508 * #2772 * #2818 * #2826 * #2848 * #2860 * #2863 * #2864 * #2866 * #2867 * #2869 * #2870 * #2871 * #2872 * #2873 * #2874 * #2875 * #2876 * #2877 * #2880 * #2881 * #2882 * #2884 * #2885 * #2886 * #2891 * #2892 * #2893 * #2894 * #2895 * #2896 * #2897 * #2898 * #2899 * #2900 * #2901 * #2902 * #2903 * #2904 * #2908 * #2909 * #2910 * #2912 * #2913 * #2914 * #2915 * #2916 * #2917 * #2918 * #2920 * #2921 * #2923 * #2924 * #2926 * #2928 * #2929 * #2930 * #2933 * #2934 * #2935 * #2936 * #2937 * #2938 * #2939 * #2942 * #2943 * #2944 * #2945 * #2946 * #2947 * #2948 * #2949 * #2950 * #2951 * #2952 * #2954 * #2955 * #2956 * #2957 * #2958 * #2959 * #2960 * #2961 * #2963 * #2964 * #2965 * #2967 * #2968 * #2969 * #2970 * #2971 * #2972 * #2974 * #2975 * #2977 * #2978 * #2980 * #2981 * #2982 * #2983 * #2984 * #2988 * #2989 * #2990 * #2991 * #2992 * #2993 * #2994 * #2995 * #2996 * #2997 * #2998 * #2999 * #3000 * #3001 * #3002 * #3004 * #3005 * #3006 * #3007 * #3008 * #3009 * #3011 * #3012 * #3013 * #3014 * #3015 * #3016 * #3018 * #3019 * #3020 * #3021 * #3022 * #3023 * #3024 * #3025 * #3026 * #3027 * #3028 * #3029 * #3030 * #3031 * #3033 * #3034 * #3035 * #3036 * #3037 * #3039 * #3040 * #3041 * #3042 * #3043 * #3044 * #3045 * #3046 * #3047 * #3048 * #3049 * #3050 * #3051 * #3052 * #3053 * #3054 * #3055 * #3056 * #3057 * #3058 * #3060 * #3061 * #3062 * #3063 * #3064 * #3065 * #3066 * #3067 * #3068 * #3069 * #3070 * #3071 * #3072 * #3073 * #3074 * #3075 * #3076 * #3077 * #3078 * #3079 * #3086 * #3087 * #3088 * #3089 * #3090 * #3091 * #3092 * #3093 * #3094 * #3095 * #3096 * #3097 * #3098 * #3099 * #3100 * #3101 * #3102 * #3103 * #3104 * #3105 * #3106 * #3107 * #3108 * #3109 * #3110 * #3112 * #3113 * #3114 * #3115 * #3116 * #3117 * #3118 * #3119 * #3120 * #3122 * #3123 * #3124 * #3127 * #3128 * #3129 * #3130 * #3131 * #3133 * #3134 * #3135 * #3136 * #3137 * #3138 * #3139 * #3140 * #3141 * #3142 * #3143 * #3144 * #3145 * #3146 * #3147 * #3148 * #3149 * #3150 * #3151 * #3152 * #3153 * #3154 * #3155 * #3157 * #3158 * #3159 * #3160 * #3161 * #3162 * #3163 * #3164 * #3165 * #3166 * #3167 * #3168 * #3169 * #3170 * #3174 * #3175 * #3176 * #3177 * #3178 * #3179 * #3181 * #3182 * #3184 * #3185 * #3186 * #3188 * #3189 * #3190 * #3191 * #3192 * #3194 * #3195 * #3196 * #3197 * #3198 * #3199 * #3200 * #3201 * #3202 * #3203 * #3205 * #3206 * #3208 * #3209 * #3210 * #3213 * #3214 * #3215 * #3216 * #3217 * #3218 * #3219 * #3220 * #3222 * #3223 * #3224 * #3225 * #3226 * #3227 * #3228 * #3229 * #3230 * #3231 * #3232 * #3233 * #3234 * #3235 * #3236 * #3237 * #3238 * #3239 * #3240 * #3241 * #3242 * #3243 * #3244 * #3246 * #3247 * #3248 * #3250 * #3251 * #3252 * #3253 * #3254 * #3255 * #3256 * #3257 * #3258 * #3259 * #3260 * #3261 * #3262 * #3263 * #3265 * #3266 * #3267 * #3268 * #3269 * #3270 * #3271 * #3272 * #3273 * #3274 * #3275 * #3276 * #3277 * #3278 * #3279 * #3280 * #3281 * #3282 * #3283 * #3284 * #3285 * #3286 * #3287 * #3288 * #3289 * #3290 * #3291

imobachgs added 9 commits February 27, 2026 11:00

Do not block storage in SetConfig calls

9160238

* Use a proxy to access D-Bus properties. * Run SetConfig on a separate Tokio task.

Add an call_future to the actors

35b7558

Temporarily disable iSCSI, bootloader and storage monitor code

115c659

Add a client to interact with the D-Bus service

01e582f

Adapt agama-storage to the new storage client

b03bd4f

Adapt agama-bootloader to the new storage client

d223c9f

Adapt agama-manager to the new storage client

3d4d562

Adapt agama-iscsi to the new storage client

9d9dfeb

Adapt agama-s390 to the new storage client

c92a060

imobachgs force-pushed the new-storage-client branch from 45c44a4 to c92a060 Compare February 27, 2026 19:45

imobachgs added 3 commits March 2, 2026 11:15

Revert "Add an call_future to the actors"

273e82a

This reverts commit 35b7558.

Make Clippy happy

d5bba05

Move iSCSI and DASD messages to separate modules

2fee0f0

imobachgs marked this pull request as ready for review March 2, 2026 12:59

Use Storage1Proxy instead of the old StorageDBusClient

c9f3644

joseivanlopez reviewed Mar 3, 2026

View reviewed changes

rust/agama-bootloader/src/client.rs Outdated Show resolved Hide resolved

rust/agama-storage-client/src/service.rs Show resolved Hide resolved

rust/agama-utils/src/lib.rs Outdated Show resolved Hide resolved

joseivanlopez reviewed Mar 3, 2026

View reviewed changes

imobachgs added 3 commits March 3, 2026 09:13

Move bootloader messages to its own module

98d4fd6

Update from code review

a663d28

Do not initialize the DASD proxy

703c3e3

joseivanlopez reviewed Mar 3, 2026

View reviewed changes

rust/agama-storage/src/monitor.rs Outdated Show resolved Hide resolved

imobachgs added 6 commits March 3, 2026 09:42

Make the dasd_proxy field as optional

7fc5c33

Load the DASD proxy configuration

f4779ea

Fix issues calculation in the storage Monitor

11024ce

Drop unused code

5ee4a12

Update changes files

53e3223

Fix agama-storage initialization in tests

afa4398

Base automatically changed from fix-blocked-storage to master March 3, 2026 11:27

joseivanlopez approved these changes Mar 3, 2026

View reviewed changes

Merge branch 'master' into new-storage-client

1204e3e

imobachgs merged commit 2ce3732 into master Mar 3, 2026
20 of 22 checks passed

imobachgs deleted the new-storage-client branch March 3, 2026 11:31

imobachgs mentioned this pull request Mar 17, 2026

Release version 19 #3292

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the attributes-based D-Bus API to prevent storage deadlocks#3220

Use the attributes-based D-Bus API to prevent storage deadlocks#3220
imobachgs merged 23 commits intomasterfrom
new-storage-client

imobachgs commented Feb 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joseivanlopez Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

imobachgs commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joseivanlopez Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

imobachgs commented Feb 27, 2026 •

edited

Loading