Security callbacks

[jreidinger]

Problem

There is missing in api-v2 security callbacks for GPG and checksum handling

Solution

Use new API to implement it.

Testing

⚠️ NONE ⚠️
TODO: test this as part of this PBI:

• https://trello.com/c/HRqBeOi7/5450-support-for-instinstallurl

[coveralls]

coverage: 61.963%. remained the same
when pulling 3d4cca5 on security_callbacks
into aabbfbc on api-v2.

[imobachgs]

Great work! Just a few comments about naming and so on. By the way, I did not review the bindings code.

[imobachgs]

I wonder why it is not part of the service's API. Perhaps when we replace the polling mechanism with something better we could move it there.

[mvidner]

How much testing did this get?

[jreidinger]

@mvidner if you mean real testing, then it is zero, I plan to give it more when we support installation.install_url or extra repositories with parameters in unattended installation ( so I can test real usage together ). I hope we are getting and closer and closer to it.

[mvidner]

Not testing progress callbacks is more or less safe because we or the users will notice.
But with security callbacks, like here, the bad case is reading about it on Hacker News.
So I put a warning to the PR description and we need a Kanban card for the testing so that it does not get lost.

[imobachgs]

Not testing progress callbacks is more or less safe because we or the users will notice. But with security callbacks, like here, the bad case is reading about it on Hacker News. So I put a warning to the PR description and we need a Kanban card for the testing so that it does not get lost.

Take into account that, when merging, the warning goes to the commit message.

[mvidner]

At this point, just adding pointers to the libzypp headers (because its API docs, generated with Doxygen, are awful: an unsearchable maze 😢 )

[imobachgs]

From the Rust's code perspective, it looks good.