Add DASD to HTTP API

[joseivanlopez]

Integrate DASD management in the new HTTP API.

[jreidinger]

Well, I have to say I really dislike this. Config struct is important part of API and here is basically nothing, depending on what dbus service provides. Basically throwing away all rust guarantees and also making it quite hard create such config e.g. even for testing purpose and you always have to use json.

[joseivanlopez]

This was a decision already taken to directly pass the json from the dbus API. It is done so for storage, iscsi, dasd, etc.

[joseivanlopez]

The validation is done with the schema. Anyway, I think dasd, zfcp and iscsi could be totally moved to rust in the future. Storage would be more complex.

[jreidinger]

sadly validation is still runtime done by checking schema against config, but not against code during compilation, which is what rust doing. So if someone breaks backward compatibility, the config will pass validation and then ruby code will fail.

[joseivanlopez]

Yes, we are aware of that. Although the ruby code will fail too if the schema changes.

[jreidinger]

and similar here. Basically no info how it looks like or how to construct it. Again even in test it forces to use json text as it is not possible to use API without json.

[joseivanlopez]

Yes, same reason than above. For now we provide schema definitions for that data and we don't want to generate the very same json twice, at dbus level and at http level.

[coveralls]

coverage: 73.899%. remained the same
when pulling f0055ca on joseivanlopez:dasd-http-api-v2
into 7b21bd9 on agama-project:master.

[jreidinger]

why it needs to be changed? I do not see reason in commit message. Basically original idea is that for progress report, you do not need to wait to be send and just send it and continue to delay if not needed.

[joseivanlopez]

I did it to guarantee that the signals arrive in order. Otherwise, ProgressFinished could come before than the last ProgressChanged.