Copy registration files at the end of the installation by jreidinger · Pull Request #3053 · agama-project/agama

jreidinger · 2026-01-20T15:44:51Z

Problem

Registration does not have its configuration neither credentials after reboot.

PBI: https://trello.com/c/fNM6lTtk/5496-copy-registration-configuration-and-credentials-to-the-final-system

Solution

Copy the configuration file and the credentials.

Testing

Tested manually.
IBS repo: https://build.suse.de/project/show/home:jreidinger:registration_finish

Scenarios:

simple reboot after registration
RMT
register with addons

rust/agama-software/src/model/registration.rs

jreidinger · 2026-01-22T10:30:34Z

rust/agama-software/src/model/registration.rs

+            std::fs::copy(path, target_path)
+                .map_err(|e| RegistrationError::IO(path.to_string(), e));
+        }
+


and here we probably should add that copy of repositories and credentials.

service/lib/agama/storage/bootloader.rb

rust/agama-software/src/zypp_server.rs

rust/agama-software/src/model/registration.rs

rust/agama-software/src/zypp_server.rs

coveralls · 2026-01-23T12:49:07Z

coverage: 73.999%. remained the same
when pulling 6abf890 on registration_finish
into dce0053 on master.

rust/package/agama.changes

rust/agama-software/src/model/registration.rs

teclator

LGTM just some small comments

Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.de>

https://build.opensuse.org/request/show/1329457 by user IGonzalezSosa + anag_factory - Fixed removing automatically selected recommended patterns (gh#agama-project/agama#3072) - Follow suit, do not package /usr/share/locale itself (gh#agama-project/agama#3071). - Copy the SCC credentials and the libzypp services (gh#agama-project/agama#3053). - Use the right architecture when regisrering a system in ppc64le (gh#agama-project/agama#3068). - Consider inst.register_url as part of the "extended configuration" (bsc#1256907). - Try to register the system even if only a registration URL was specified (without a code). - When the registration fails, retry it on the next SetConfig call. - Allow importing SSL certificates from registration servers (gh#agama-project/agama#3055). - Fix enabling NetworkManager service in the target system (gh#agama-project/agam

… 34 via SR 1329458 https://build.opensuse.org/request/show/1329458 by user IGonzalezSosa + anag_factory - Provide new D-Bus API for iSCSI (gh#agama-project/agama#3008). - Temporarily disable the check of os-prober to avoid trying to access libzypp (gh#agama-project/agama#3053). - Drop dependency on dmraid (jsc#PED-15368) - Stop reporting a bootloader error when there is no valid storage proposal (bsc#1257013).

Prepare to release version 19. * #1829 * #2508 * #2772 * #2818 * #2826 * #2848 * #2860 * #2863 * #2864 * #2866 * #2867 * #2869 * #2870 * #2871 * #2872 * #2873 * #2874 * #2875 * #2876 * #2877 * #2880 * #2881 * #2882 * #2884 * #2885 * #2886 * #2891 * #2892 * #2893 * #2894 * #2895 * #2896 * #2897 * #2898 * #2899 * #2900 * #2901 * #2902 * #2903 * #2904 * #2908 * #2909 * #2910 * #2912 * #2913 * #2914 * #2915 * #2916 * #2917 * #2918 * #2920 * #2921 * #2923 * #2924 * #2926 * #2928 * #2929 * #2930 * #2933 * #2934 * #2935 * #2936 * #2937 * #2938 * #2939 * #2942 * #2943 * #2944 * #2945 * #2946 * #2947 * #2948 * #2949 * #2950 * #2951 * #2952 * #2954 * #2955 * #2956 * #2957 * #2958 * #2959 * #2960 * #2961 * #2963 * #2964 * #2965 * #2967 * #2968 * #2969 * #2970 * #2971 * #2972 * #2974 * #2975 * #2977 * #2978 * #2980 * #2981 * #2982 * #2983 * #2984 * #2988 * #2989 * #2990 * #2991 * #2992 * #2993 * #2994 * #2995 * #2996 * #2997 * #2998 * #2999 * #3000 * #3001 * #3002 * #3004 * #3005 * #3006 * #3007 * #3008 * #3009 * #3011 * #3012 * #3013 * #3014 * #3015 * #3016 * #3018 * #3019 * #3020 * #3021 * #3022 * #3023 * #3024 * #3025 * #3026 * #3027 * #3028 * #3029 * #3030 * #3031 * #3033 * #3034 * #3035 * #3036 * #3037 * #3039 * #3040 * #3041 * #3042 * #3043 * #3044 * #3045 * #3046 * #3047 * #3048 * #3049 * #3050 * #3051 * #3052 * #3053 * #3054 * #3055 * #3056 * #3057 * #3058 * #3060 * #3061 * #3062 * #3063 * #3064 * #3065 * #3066 * #3067 * #3068 * #3069 * #3070 * #3071 * #3072 * #3073 * #3074 * #3075 * #3076 * #3077 * #3078 * #3079 * #3086 * #3087 * #3088 * #3089 * #3090 * #3091 * #3092 * #3093 * #3094 * #3095 * #3096 * #3097 * #3098 * #3099 * #3100 * #3101 * #3102 * #3103 * #3104 * #3105 * #3106 * #3107 * #3108 * #3109 * #3110 * #3112 * #3113 * #3114 * #3115 * #3116 * #3117 * #3118 * #3119 * #3120 * #3122 * #3123 * #3124 * #3127 * #3128 * #3129 * #3130 * #3131 * #3133 * #3134 * #3135 * #3136 * #3137 * #3138 * #3139 * #3140 * #3141 * #3142 * #3143 * #3144 * #3145 * #3146 * #3147 * #3148 * #3149 * #3150 * #3151 * #3152 * #3153 * #3154 * #3155 * #3157 * #3158 * #3159 * #3160 * #3161 * #3162 * #3163 * #3164 * #3165 * #3166 * #3167 * #3168 * #3169 * #3170 * #3174 * #3175 * #3176 * #3177 * #3178 * #3179 * #3181 * #3182 * #3184 * #3185 * #3186 * #3188 * #3189 * #3190 * #3191 * #3192 * #3194 * #3195 * #3196 * #3197 * #3198 * #3199 * #3200 * #3201 * #3202 * #3203 * #3205 * #3206 * #3208 * #3209 * #3210 * #3213 * #3214 * #3215 * #3216 * #3217 * #3218 * #3219 * #3220 * #3222 * #3223 * #3224 * #3225 * #3226 * #3227 * #3228 * #3229 * #3230 * #3231 * #3232 * #3233 * #3234 * #3235 * #3236 * #3237 * #3238 * #3239 * #3240 * #3241 * #3242 * #3243 * #3244 * #3246 * #3247 * #3248 * #3250 * #3251 * #3252 * #3253 * #3254 * #3255 * #3256 * #3257 * #3258 * #3259 * #3260 * #3261 * #3262 * #3263 * #3265 * #3266 * #3267 * #3268 * #3269 * #3270 * #3271 * #3272 * #3273 * #3274 * #3275 * #3276 * #3277 * #3278 * #3279 * #3280 * #3281 * #3282 * #3283 * #3284 * #3285 * #3286 * #3287 * #3288 * #3289 * #3290 * #3291

jreidinger added 5 commits January 20, 2026 16:42

implement registration finish

809ae5a

cargo fmt

66e389e

Merge branch 'master' into registration_finish

5d2bd2e

use new os-prober feature to avoid packager init

9d86f39

fix product in announce example

5171ebf

jreidinger commented Jan 22, 2026

View reviewed changes

rust/agama-software/src/model/registration.rs Outdated Show resolved Hide resolved

jreidinger commented Jan 22, 2026

View reviewed changes

rust/agama-software/src/model/registration.rs Outdated Show resolved Hide resolved

jreidinger commented Jan 22, 2026

View reviewed changes

service/lib/agama/storage/bootloader.rb Show resolved Hide resolved

imobachgs reviewed Jan 23, 2026

View reviewed changes

imobachgs added 4 commits January 23, 2026 10:52

Merge branch 'master' into registration_finish

14a4923

wip

38b4885

Add a install_dir to the software service

773ea0c

Fix the copy of credentials files

6abf890

imobachgs added 2 commits January 23, 2026 13:19

Add a helper function to copy files

e4bda2a

Copy registration servcices to the target system

143fb95

imobachgs changed the title ~~implement registration finish~~ Copy registration files at the end of the installation Jan 23, 2026

imobachgs added 5 commits January 23, 2026 13:45

Fix test_start_zypp_server

197ee00

Update yast2-booloader dependency

19f3977

Update changes files

39d9c1e

Merge branch 'master' into registration_finish

4cd23fe

Fix manager tests

f375299

imobachgs marked this pull request as ready for review January 23, 2026 14:41

teclator reviewed Jan 23, 2026

View reviewed changes

rust/package/agama.changes Outdated Show resolved Hide resolved

teclator reviewed Jan 23, 2026

View reviewed changes

rust/agama-software/src/model/registration.rs Outdated Show resolved Hide resolved

teclator approved these changes Jan 23, 2026

View reviewed changes

Apply suggestions from code review

c139423

Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.de>

imobachgs merged commit c81ead7 into master Jan 23, 2026
19 of 20 checks passed

imobachgs deleted the registration_finish branch January 23, 2026 15:24

imobachgs mentioned this pull request Mar 17, 2026

Release version 19 #3292

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy registration files at the end of the installation#3053

Copy registration files at the end of the installation#3053
imobachgs merged 17 commits intomasterfrom
registration_finish

jreidinger commented Jan 20, 2026 •

edited by imobachgs

Loading

Uh oh!

Uh oh!

Uh oh!

jreidinger Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jan 23, 2026

Uh oh!

Uh oh!

Uh oh!

teclator left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jreidinger commented Jan 20, 2026 • edited by imobachgs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing

Uh oh!

Uh oh!

Uh oh!

jreidinger Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jan 23, 2026

Uh oh!

Uh oh!

Uh oh!

teclator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jreidinger commented Jan 20, 2026 •

edited by imobachgs

Loading