Returns error status if asked for install action and backend detects issues

[mchf]

Problem

It is possible to start installation via CLI / API even when configuration in the backend contains issues.

Solution

Send reply with status 422 in such case

Testing

• Tested manually

[mchf]

Problem

It is possible to start installation via CLI / API even when configuration in the backend contains issues.

Solution

Send reply with status 422 in such case

Testing

TODO:

• Tested manually

[coveralls]

coverage: 72.998%. remained the same
when pulling 5fb7462 on check_issues_backend
into 07e213e on master.

[mchf]

Here is test via API:

curl -X POST \
  -H @headers.txt \
  -H "Content-Type: application/json" \
  -d '{ "install": null }' \
  -k \
  $AGAMA_URL/api/v2/action

returns:

However could not test it through CLI - it was for some reason unable to connect to the server.

[kobliha]

Fixing https://bugzilla.suse.com/show_bug.cgi?id=1256951 (AKA Agama return code not set correctly)?

[mchf]

Fixing https://bugzilla.suse.com/show_bug.cgi?id=1256951 (AKA Agama return code not set correctly)?

I don't think so. This PR is about detecting whether backend sees some issues and block install action if so ... and report it back with specific http error status.

The bug on the other hand seems as invalid processing of returned errors in the CLI client. It seems, for the first read, that it always "exit 0" even when the backend cannot proceed and returns an error status.

[mchf]

Agama CLI already deals with existing issue in own way here:
https://github.com/agama-project/agama/blob/master/rust/agama-cli/src/lib.rs#L120
So errors sent from backend goes this way:
https://github.com/agama-project/agama/blob/master/rust/agama-cli/src/lib.rs#L125
Which leads to:
https://github.com/agama-project/agama/blob/master/rust/agama-cli/src/main.rs#L29

[imobachgs]

LGTM. It is up to you whether you want to use the new IsEmpty message. Perhaps we can move on and introduce that change later (when the time pressure is not so high).

[imobachgs]

We recently introduced a new action to check whether the progress is empty or not. See

agama/rust/agama-manager/src/service.rs

Line 524 in dce0053

let is_empty = self

.

Perhaps you want to give it a try (it is available in master).