Merge the storage config

[imobachgs]

Problem

The storage configuration is not merged, just replaced.

Solution

Merge the first level of the storage section. The legacy_autoyast_storage is still replaced as it only contains a drives list.

Testing

• Added a new unit test

[joseivanlopez]

I would expect right_object takes precedence, for example:

config.storage.drives = ...
other.storage.drives = ...
config.storage.drives == other.storage.drives #=> false
config.merge(other)
config.storage.drives == other.storage.drives #=> true

With the current implementation, #merge actually means "set to the left object the missing properties provided by the right object". I expected this other meaning: "set to the left object all the properties provided by the right object". What do you think?

[imobachgs]

I understand your confusion, but in merge the left side is the "new configuration". Think about the "right" object as the default values (that belongs to the old configuration). So I would expect to use the "left" values if available.

[imobachgs]

Thinking about this, I could have implemented this as a separate strategy, but as I do not expect to reuse it, implementing Merge looks fine.

[joseivanlopez]

LGTM