Skip to content

Multiple fixes in the registration page#3061

Merged
imobachgs merged 17 commits intomasterfrom
fix-registration
Jan 22, 2026
Merged

Multiple fixes in the registration page#3061
imobachgs merged 17 commits intomasterfrom
fix-registration

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Jan 22, 2026

Problem

The goal of this PR is to bring the registration page to an usable state, fixing other registration-related problems along the way.

Solution

Changes in the web UI:

  • Allow registering add-ons (gh#Multiple fixes in the registration page #3061).
  • Improve error reporting in the registration page.
  • Do not block the UI when registering the system (bsc#1257105).
  • Do not allow to change the product when it is already registered.

Changes in the backend:

  • Consider inst.register_url as part of the "extended configuration" (bsc#1256907).
  • Try to register the system even if only a registration URL was specified (without a code).
  • When the registration fails, retry it on the next SetConfig call.

Testing

  • Added a new unit test
  • Tested manually

Screenshots

Not registered system Captura desde 2026-01-22 12-16-27
Registration error Captura desde 2026-01-22 12-16-03
Registered system Captura desde 2026-01-22 12-13-58

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 22, 2026

Coverage Status

coverage: 73.989% (+1.0%) from 72.987%
when pulling 80b972a on fix-registration
into 2c9c2d0 on master.

@imobachgs imobachgs marked this pull request as ready for review January 22, 2026 16:41
Copy link
Copy Markdown
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import { patchConfig } from "~/api";
import { Navigate } from "react-router";
import { patchConfig, putConfig } from "~/api";
import { Issue } from "~/model/issue";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember we're now using import type when importing a type.

Comment on lines +38 to +39
import { Issue } from "~/model/issue";
import { Addon } from "~/model/config/product";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and from now on. We're using import type instead just import

@imobachgs imobachgs merged commit 3c074a0 into master Jan 22, 2026
14 checks passed
@imobachgs imobachgs deleted the fix-registration branch January 22, 2026 17:04
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 28, 2026
https://build.opensuse.org/request/show/1329459
by user IGonzalezSosa + anag_factory
- Fixed removing automatically selected recommended patterns
  (gh#agama-project/agama#3072)

- Allow registering add-ons (gh#agama-project/agama#3061).
- Improve error reporting in the registration page.
- Do not block the UI when registering the system (bsc#1257105).
- Do not allow to change the product when it is already registered.

- Track state (collapsed/open) of the lists of logical volumes
  (gh#agama-project/agama#3066).

- Avoid inconsistent state (collapsed/open) in the lists of
  partitions (gh#agama-project/agama#3063).

- Updated top header install button label to clarify navigation to
  the overview page (gh#agama-project/agama#3060).
@imobachgs imobachgs mentioned this pull request Mar 17, 2026
imobachgs added a commit that referenced this pull request Mar 17, 2026
Prepare to release version 19.

* #1829
* #2508
* #2772
* #2818
* #2826
* #2848
* #2860
* #2863
* #2864
* #2866
* #2867
* #2869
* #2870
* #2871
* #2872
* #2873
* #2874
* #2875
* #2876
* #2877
* #2880
* #2881
* #2882
* #2884
* #2885
* #2886
* #2891
* #2892
* #2893
* #2894
* #2895
* #2896
* #2897
* #2898
* #2899
* #2900
* #2901
* #2902
* #2903
* #2904
* #2908
* #2909
* #2910
* #2912
* #2913
* #2914
* #2915
* #2916
* #2917
* #2918
* #2920
* #2921
* #2923
* #2924
* #2926
* #2928
* #2929
* #2930
* #2933
* #2934
* #2935
* #2936
* #2937
* #2938
* #2939
* #2942
* #2943
* #2944
* #2945
* #2946
* #2947
* #2948
* #2949
* #2950
* #2951
* #2952
* #2954
* #2955
* #2956
* #2957
* #2958
* #2959
* #2960
* #2961
* #2963
* #2964
* #2965
* #2967
* #2968
* #2969
* #2970
* #2971
* #2972
* #2974
* #2975
* #2977
* #2978
* #2980
* #2981
* #2982
* #2983
* #2984
* #2988
* #2989
* #2990
* #2991
* #2992
* #2993
* #2994
* #2995
* #2996
* #2997
* #2998
* #2999
* #3000
* #3001
* #3002
* #3004
* #3005
* #3006
* #3007
* #3008
* #3009
* #3011
* #3012
* #3013
* #3014
* #3015
* #3016
* #3018
* #3019
* #3020
* #3021
* #3022
* #3023
* #3024
* #3025
* #3026
* #3027
* #3028
* #3029
* #3030
* #3031
* #3033
* #3034
* #3035
* #3036
* #3037
* #3039
* #3040
* #3041
* #3042
* #3043
* #3044
* #3045
* #3046
* #3047
* #3048
* #3049
* #3050
* #3051
* #3052
* #3053
* #3054
* #3055
* #3056
* #3057
* #3058
* #3060
* #3061
* #3062
* #3063
* #3064
* #3065
* #3066
* #3067
* #3068
* #3069
* #3070
* #3071
* #3072
* #3073
* #3074
* #3075
* #3076
* #3077
* #3078
* #3079
* #3086
* #3087
* #3088
* #3089
* #3090
* #3091
* #3092
* #3093
* #3094
* #3095
* #3096
* #3097
* #3098
* #3099
* #3100
* #3101
* #3102
* #3103
* #3104
* #3105
* #3106
* #3107
* #3108
* #3109
* #3110
* #3112
* #3113
* #3114
* #3115
* #3116
* #3117
* #3118
* #3119
* #3120
* #3122
* #3123
* #3124
* #3127
* #3128
* #3129
* #3130
* #3131
* #3133
* #3134
* #3135
* #3136
* #3137
* #3138
* #3139
* #3140
* #3141
* #3142
* #3143
* #3144
* #3145
* #3146
* #3147
* #3148
* #3149
* #3150
* #3151
* #3152
* #3153
* #3154
* #3155
* #3157
* #3158
* #3159
* #3160
* #3161
* #3162
* #3163
* #3164
* #3165
* #3166
* #3167
* #3168
* #3169
* #3170
* #3174
* #3175
* #3176
* #3177
* #3178
* #3179
* #3181
* #3182
* #3184
* #3185
* #3186
* #3188
* #3189
* #3190
* #3191
* #3192
* #3194
* #3195
* #3196
* #3197
* #3198
* #3199
* #3200
* #3201
* #3202
* #3203
* #3205
* #3206
* #3208
* #3209
* #3210
* #3213
* #3214
* #3215
* #3216
* #3217
* #3218
* #3219
* #3220
* #3222
* #3223
* #3224
* #3225
* #3226
* #3227
* #3228
* #3229
* #3230
* #3231
* #3232
* #3233
* #3234
* #3235
* #3236
* #3237
* #3238
* #3239
* #3240
* #3241
* #3242
* #3243
* #3244
* #3246
* #3247
* #3248
* #3250
* #3251
* #3252
* #3253
* #3254
* #3255
* #3256
* #3257
* #3258
* #3259
* #3260
* #3261
* #3262
* #3263
* #3265
* #3266
* #3267
* #3268
* #3269
* #3270
* #3271
* #3272
* #3273
* #3274
* #3275
* #3276
* #3277
* #3278
* #3279
* #3280
* #3281
* #3282
* #3283
* #3284
* #3285
* #3286
* #3287
* #3288
* #3289
* #3290
* #3291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants