Skip to content

Returns error status if asked for install action and backend detects issues #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mchf merged 5 commits into from
Jan 23, 2026
Merged

Returns error status if asked for install action and backend detects issues #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82d4f78
Adapted server's IntoResponse for Error to return different statuses
mchf Jan 21, 2026
182900c
Error if manager service is asked for Install action and finds issues
mchf Jan 21, 2026
a58ffe7
Formatting
mchf Jan 21, 2026
4784ef3
If list of running progresses is nonempty, block the installation
mchf Jan 21, 2026
5fb7462
Modified returned status code for InstallationBlocke error
mchf Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions rust/agama-manager/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ pub enum Error {
Hardware(#[from] hardware::Error),
#[error("Cannot dispatch this action in {current} stage (expected {expected}).")]
UnexpectedStage { current: Stage, expected: Stage },
#[error("Cannot start the installation. The config contains some issues.")]
InstallationBlocked,
#[error(transparent)]
Users(#[from] users::service::Error),
}
Expand Down Expand Up @@ -686,6 +688,13 @@ impl MessageHandler<message::GetLicense> for Service {
impl MessageHandler<message::RunAction> for Service {
/// It runs the given action.
async fn handle(&mut self, message: message::RunAction) -> Result<(), Error> {
let issues = self.issues.call(issue::message::Get).await?;
let progress = self.progress.call(progress::message::GetProgress).await?;
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently introduced a new action to check whether the progress is empty or not. See

agama/rust/agama-manager/src/service.rs

Line 524 in dce0053

let is_empty = self
.

Perhaps you want to give it a try (it is available in master).


if !issues.is_empty() || !progress.is_empty() {
return Err(Error::InstallationBlocked);
}

match message.action {
Action::ConfigureL10n(config) => {
self.check_stage(Stage::Configuring).await?;
Expand Down
11 changes: 9 additions & 2 deletions rust/agama-server/src/server/web.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

use crate::server::config_schema;
use agama_lib::{error::ServiceError, logs};
use agama_manager::service::Error::InstallationBlocked;
use agama_manager::{self as manager, message};
use agama_software::Resolvable;
use agama_utils::{
Expand Down Expand Up @@ -66,7 +67,12 @@ impl IntoResponse for Error {
let body = json!({
"error": self.to_string()
});
(StatusCode::BAD_REQUEST, Json(body)).into_response()
let status = if matches!(self, Error::Manager(InstallationBlocked)) {
StatusCode::UNPROCESSABLE_ENTITY
} else {
StatusCode::BAD_REQUEST
};
(status, Json(body)).into_response()
}
}

Expand Down Expand Up @@ -398,7 +404,8 @@ async fn get_license(
context_path = "/api/v2",
responses(
(status = 200, description = "Action successfully run."),
(status = 400, description = "Not possible to run the action.", body = Object)
(status = 400, description = "Not possible to run the action.", body = Object),
(status = 422, description = "Action blocked by backend state", body = Object)
),
params(
("action" = Action, description = "Description of the action to run."),
Expand Down
Loading