-
Notifications
You must be signed in to change notification settings - Fork 74
Add support for files/scripts #2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
af3ce63
Drop files and scripts HTTP API
imobachgs c609dec
Extract agama_lib::utils::transfer to a separate package
imobachgs 279eb20
Rename TransferError to Error
imobachgs 96f4a67
agama-utils depends on agama-transfer
imobachgs e317d3a
Move from agama_lib::files to agama-utils
imobachgs 0583d0a
Move agama_lib::scripts to agama-utils
imobachgs e77e9c2
Drop files and scripts from InstallSettings
imobachgs d048fad
Drop OpenAPI documentation of the old scripts API
imobachgs 0784d32
Add a test_utils module for agama-software
imobachgs ac2fa82
Add a new agama-files package
imobachgs 1751123
Implement the files service
imobachgs 369757f
Use the new files service
imobachgs fc13ee9
Use a dummy software service during tests
imobachgs 8e1785a
Add more debugging
imobachgs cc00fea
Make running more reliable
imobachgs e9b240d
Update from code review
imobachgs 2da33b9
Drop unneeded call to Vec::clear
imobachgs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| [package] | ||
| name = "agama-files" | ||
| version = "0.1.0" | ||
| rust-version.workspace = true | ||
| edition.workspace = true | ||
|
|
||
| [dependencies] | ||
| agama-software = { version = "0.1.0", path = "../agama-software" } | ||
| agama-utils = { path = "../agama-utils" } | ||
| async-trait = "0.1.89" | ||
| tempfile = "3.23.0" | ||
| thiserror = "2.0.17" | ||
| tokio = { version = "1.48.0", features = ["sync"] } | ||
|
|
||
| [dev-dependencies] | ||
| tokio-test = "0.4.4" | ||
| test-context = "0.4.1" | ||
| serde_json = "1.0.145" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change all std::Commands to tokio::Command due to async nature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, definitely. I will check them in a separate PR.