Merged
Conversation
Commit Message: add QUIC upstream stream reset error stats. Risk Level: Low Testing: Unit tests Docs Changes: Release Notes: n/a. Signed-off-by: Renjie Tang <renjietang@google.com>
Rejecting invalid config which only partially configures HTTP/3 Risk Level: low (validates broken config) Testing: new unit tests Docs Changes: n/a Release Notes: n/a Fixes #15985 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: qinggniq <livewithblank@gmail.com>
Replace the confusing word with official defination Signed-off-by: Le Yao <le.yao@intel.com>
#17522) The idle callback was incorrectly going through the ThreadLocalClusterManagerImpl::ClusterEntry to reach the ThreadLocalClusterManager. The pool is owned by the ThreadLocalClusterManager, not by the ClusterEntry, so the reference to the ClusterEntry could be dangling, resulting in a crash. fixes commit #17403 Signed-off-by: Greg Greenway <ggreenway@apple.com>
Risk Level: low Testing: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Ryan Northey <ryan@synca.io>
Risk Level: low Testing: new unit tests Docs Changes: updated API docs Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: inline Fixes #16006 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Commit Message: Remove support of Google QUIC. QUICHE supports both IETF QUIC and Google QUIC. Given that IETF QUIC has been launched by Google and Google QUIC will be deprecated soon, remove the support of Google QUIC will lower the future maintenance burden. Risk Level: low Testing: existing tests passed Fixes #16642 Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Chris Xin <xinchuantao@qq.com>
This is PR 4/5 towards adding shadowing support. This moves the last bits needed to implement shadowing while reusing as much as possible. The next and final PR will be big, but with very few duplicate parts (if any, and they'll be small anyway). Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
* Add flag to skip test processing Support flag to skip test processing so that the CI jobs can be re-used for internal builds (which may have their own test-result processing or not want to use the default result-publishing). Signed-off-by: John Murray <murray@stripe.com>
…lls (+… (#17528) Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
…7548) Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Ulf Adams <ulf@engflow.com>
…ry. (#17093) This PR tracks memory accounts using >1MB of allocated space, with feedback mechanisms based on credits and debits on accounts. It further creates the handle from which the BufferMemoryAccount can reset the stream, and has the WatermarkBufferFactory also produce the particular BufferMemoryAccountImpl used for tracking. Risk Level: Medium Testing: Unit and Integration test Docs Changes: NA Release Notes: NA -- not yet user facing Platform Specific Features: NA Runtime guard: Yes, envoy.test_only.per_stream_buffer_accounting from #16218 sufficient Related Issue #15791 Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
use one destination port range rule to cover thousands of port rules in RBAC permissions, adding convenience for writing configuration and making matching quicker Risk Level: Low Testing: Unit Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Fixes #16039 Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
Signed-off-by: qinggniq <livewithblank@gmail.com>
Risk Level: Low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
- Canonicalizing query string - Canonicalizing path string - Adding tests for canonical path and query Ref: https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html Issue: #16918 Signed-off-by: Yathish Gangolli <yathishsg@gmail.com>
Risk Level: n/a Testing: manual Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
…single filename argument without ./ (#17937) Signed-off-by: John Esmet <john.esmet@gmail.com>
`context_extenstions` map has the potential to contain secrets which need to be redacted from config dumps. Risk Level: Low Signed-off-by: Paul Gallagher <pgal@google.com>
Update the 14 day API compatibility exception to make it clear that whether a field has already been included in an Envoy release may affect whether incompatible changes should be made. This updates #17920. Signed-off-by: James Peach <jpeach@apache.org>
…17950) Commit Message: cluster manager - change underlying call chain for drainConnections Additional Description: previously drainConnections used ConnPool::startDrain which does not guarantee that non-idle connections will not be used for new streams. This change leverages the logic in onHostHealthFailure to close idle connections and mark non-idle connections as draining so that new streams are forced onto new connections. Risk Level: low - API usage is opt in Testing: existing tests. Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Filter to transform response to Signed HTTP Exchange (SXG) package using libsxg (https://github.com/google/libsxg). Signed-off-by: Chris Papazian <papazian@pinterest.com>
- Removed the JsonV1Serializer and added exception for HTTP_JSON_V1version in Serializer creation.
- Specified collector_endpoint_version in the test
- Removed the default value for endpoint_, it is redundant here because in the zipkin.proto, it has PGV rule [(validate.rules).string = {min_len: 1}], so we always need to provide the config for this field.
- Modified the ConstructBuffer test to create the buffer using ZipkinConfig::HTTP_JSON
Risk Level: LOW
Testing: CI
Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Client connection can be created with least changes using underlying user space io socket per comment #16763 Risk Level: low Testing: unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Use a helper to run or enqueue a pending callback when there isn't significant copying involved. Risk Level: low Testing: existing unit tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Taylor Barrella <tabarr@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
…17721) Support extraction of JWT from Cookies in JWT Extension Added "from_cookies" config directive to jwt_authn that enables JWT extraction from request cookies. Risk Level: low Testing: unit tests Docs Changes: Updated `docs/root/configuration/http/http_filters/jwt_authn_filter.rst` Release Notes: Updated `docs/root/version_history/current.rst` Platform Specific Features: None Fixes #17424 Signed-off-by: Shubham Patil <theshubhamp@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Commit Message: add metrics service config example Additional Description: Risk Level: Testing: Docs Changes: add metrics service config example Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
…ing (#17916) Risk Level: LOW Testing: local unit test, CI Signed-off-by: Tianyu Xia <tyxia@google.com>
Change the log level of decompressing/not decompressing message from debug to trace since these are pretty noisy and seem to belong to trace, not debug. Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Derek Argueta <darguetap@gmail.com>
…cing extension (#17947) `locality_weights` is currently calculated only when the cluster contains a `common_lb_config` containing a locality weighted config. This allows load balancing extensions to receive `locality_weights`. In the future, it might be preferable to have the load balancing policy indicate, programatically, whether it needs the locality weights, as an optimization in cases where it doesn't. This commit also pulls the custom LB used in `CustomStaticCluster` into its own library so that it can be re-used. Signed-off-by: Eugene Chan <eugenechan@google.com>
Commit Message: Improve cpu and memory usage of the sink for counters, gauges and text readouts by: Iterating over stats in the store to create a snapshot (instead of creating a vector by iterating over scopes.) Additional Description: Risk Level: Low Testing: Added benchmark test for stats sink. Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Benchmark test results of server_stats_flush_benchmark_test: With change: name cpu/op bmFlushToSinks/10 778ns ± 1% bmFlushToSinks/100 2.83µs ± 3% bmFlushToSinks/1000 39.5µs ± 1% bmFlushToSinks/10000 409µs ± 4% bmFlushToSinks/100000 6.07ms ±19% bmFlushToSinks/1000000 100ms ± 4% Without change: name cpu/op bmFlushToSinks/10 4.44µs ± 4% bmFlushToSinks/100 31.4µs ± 2% bmFlushToSinks/1000 376µs ± 2% bmFlushToSinks/10000 5.40ms ± 7% bmFlushToSinks/100000 90.1ms ± 4% bmFlushToSinks/1000000 1.59s ± 4% Signed-off-by: Pradeep Rao <pcrao@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]