thrift proxy: DRY things up a bit#17930
Merged
zuercher merged 4 commits intoenvoyproxy:mainfrom Sep 2, 2021
Merged
Conversation
Use a helper to run or enqueue a pending callback when there isn't significant copying involved. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
…-requests-cleanup
zuercher
reviewed
Sep 1, 2021
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Generally looks good. One question about a lambda definition and a style nit.
source/extensions/filters/network/thrift_proxy/router/shadow_writer_impl.cc
Show resolved
Hide resolved
source/extensions/filters/network/thrift_proxy/router/shadow_writer_impl.h
Outdated
Show resolved
Hide resolved
added 2 commits
September 1, 2021 14:19
…-requests-cleanup
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
zuercher
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a helper to run or enqueue a pending callback when there isn't
significant copying involved.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com