listener: add listen() error handling#17427
Conversation
Related to #14784 Signed-off-by: Matt Klein <mklein@lyft.com>
|
This has some test ASAN issues that I need to fix, but more importantly it looks like some of the integration tests on Windows are actually failing now because listen() is failing. That doesn't seem good. cc @envoyproxy/windows-dev /wait |
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
|
I pushed a fix for ASAN but that needs more scrutiny as it seems like a real bug in the init manager code. cc @htuch. I still need help from @davinci26 next week to fix the Windows issues. /wait |
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
|
@davinci26 now that you are back from vacation are you able to help me sort out the Windows failures? I can either add a patch to this PR if you want to fix the listen calls in a different PR I can then merge that into this. LMK. |
|
I am back today and looking into it. Let me see first how big the change is, if the patch is small, I will paste it here otherwise I will push a separate PR |
Signed-off-by: Matt Klein <mklein@lyft.com>
|
@davinci26 updated PTAL |
davinci26
left a comment
davinci26
left a comment
There was a problem hiding this comment.
thanks for adding the TODOS, I am looking into them
|
/retest |
|
Retrying Azure Pipelines: |
…bridge-stream * upstream/main: (32 commits) tls: move ssl connection info into SocketAddressProvider (envoyproxy#17334) conn pool: default enable runtime feature `conn_pool_delete_when_idle` (envoyproxy#17577) api: LEDS api introduction (envoyproxy#17419) kafka: add support for api versions request in mesh-filter (envoyproxy#17475) ext_proc: Implement BUFFERED_PARTIAL processing mode (envoyproxy#17531) tooling: Async/pathlib/mypy cleanups and utils (envoyproxy#17505) xds: restructure CertificateProvider fields (envoyproxy#17201) Refactor OverloadIntegrationTest breaking out a test base, and the fake resource monitors. (envoyproxy#17530) listener: move active connection collection out of active tcp listener (envoyproxy#16947) tools: format checks for backticks (envoyproxy#17566) coverage: set lower limit for common/quic and common (envoyproxy#17573) v2: final source removal (envoyproxy#17565) test: bumping coverage (envoyproxy#17564) quic: enforcing header size and contents (envoyproxy#17520) Support for canonicalizing URI properly for AWS SigV4 signer (envoyproxy#17137) listener: add a stat for transport socket connect timeout (envoyproxy#17458) listener: add listen() error handling (envoyproxy#17427) http: return per route config when direct response is set (envoyproxy#17449) removing most v2 references from source/ (envoyproxy#17415) bug fix: return bootstrap when validating config (envoyproxy#17499) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
5 participants
Related to #14784
Signed-off-by: Matt Klein mklein@lyft.com
Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A