examples: fix go-control-plane code after API breakage#17549
Merged
phlax merged 2 commits intoenvoyproxy:mainfrom Jul 30, 2021
Merged
examples: fix go-control-plane code after API breakage#17549phlax merged 2 commits intoenvoyproxy:mainfrom
phlax merged 2 commits intoenvoyproxy:mainfrom
Conversation
envoyproxy/go-control-plane#475 added a param to NewSnapshot Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
Author
|
fyi @alecholmez @Xunzhuo |
phlax
previously approved these changes
Jul 30, 2021
Contributor
|
Ah thank you, I missed this example stuff |
Member
|
@snowp this seems to have fixed bringing up g-c-p but not the example itself, not sure why: |
Contributor
Author
|
Hmm I can't really tell either, perhaps it's failing when cleaning up the Docker network? /retest |
|
Retrying Azure Pipelines: |
Member
|
its not able to curl the test page afaict - ie envoy's not getting updated or something |
Contributor
Author
|
@phlax I added a sleep and that seems to have done the trick /shrug |
phlax
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envoyproxy/go-control-plane#475 added a param to NewSnapshot
Signed-off-by: Snow Pettersen snowp@lyft.com
Risk Level: Low, example only
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a