bug fix: return bootstrap when validating config

[qinggniq]

Signed-off-by: qinggniq livewithblank@gmail.com

fix #17344

Commit Message: fix unimplemented panic when validating config, ref #17344
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

[asraa]

Thanks for the fix! Do you mind adding a regression test with a config containing ext_authz ?

[asraa]

Thanks! But if the regression test is never run, then it's not quite a test.

Maybe you could add it to ext_authz_integration_test?

envoy/test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc

Lines 734 to 768 in 042b882

	TEST_P(ExtAuthzLocalReplyIntegrationTest, DeniedHeaderTest) {
	config_helper_.addConfigModifier([this](envoy::config::bootstrap::v3::Bootstrap& bootstrap) {
	auto* ext_authz_cluster = bootstrap.mutable_static_resources()->add_clusters();
	ext_authz_cluster->MergeFrom(bootstrap.static_resources().clusters()[0]);
	ext_authz_cluster->set_name("ext_authz");
	envoy::extensions::filters::http::ext_authz::v3::ExtAuthz proto_config;
	const std::string ext_authz_config = R"EOF(
	transport_api_version: V3
	http_service:
	server_uri:
	uri: "ext_authz:9000"
	cluster: "ext_authz"
	timeout: 300s
	)EOF";
	TestUtility::loadFromYaml(ext_authz_config, proto_config);
	envoy::config::listener::v3::Filter ext_authz_filter;
	ext_authz_filter.set_name("envoy.filters.http.ext_authz");
	ext_authz_filter.mutable_typed_config()->PackFrom(proto_config);
	config_helper_.addFilter(MessageUtil::getJsonStringFromMessageOrDie(ext_authz_filter));
	});
	const std::string local_reply_yaml = R"EOF(
	body_format:
	json_format:
	code: "%RESPONSE_CODE%"
	message: "%LOCAL_REPLY_BODY%"
	)EOF";
	envoy::extensions::filters::network::http_connection_manager::v3::LocalReplyConfig
	local_reply_config;
	TestUtility::loadFromYaml(local_reply_yaml, local_reply_config);
	config_helper_.setLocalReply(local_reply_config);
	HttpIntegrationTest::initialize();

(Since extensions shouldn't be loaded into test/server:server_test. Please check that it failed before the fix and is fixed after.

[qinggniq]

@asraa Sorry for not explain this clearly. I think this PR is very similar with #15932. This PR fixed that an unimplemented method in ValidateInstance at source/server/config_validation/server.h causing crash when validating config which contain ext_authz. So I added envoy-ext_authz.yaml to let //test/server/config_validation:server_test to validate this config.

[qinggniq]

But the new added config seems not really be validated, I'll take a further look.

[asraa]

Thanks so much for fixing the test and adding the comment to the issue link! LGTM

[asraa]

@envoyproxy/senior-maintainers just a very quick pass for a final merge. LGTM

[travisgroth]

/backport

Nominating for backport as a stability fix. I believe it only needs to land on 1.19.