add metrics service config example#17464
Merged
lizan merged 12 commits intoenvoyproxy:mainfrom Sep 3, 2021
Merged
Conversation
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
dmitri-d
reviewed
Jul 27, 2021
dmitri-d
reviewed
Jul 27, 2021
dmitri-d
reviewed
Jul 27, 2021
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Contributor
Author
|
@phlax Hi, I am not very familiar with the format, could you give me a comment about how to fix CI fails? thanks |
Contributor
|
if you click through the failure you should be able to find logs. alternately running the "fix_format" scripts via ci/do_ci.sh may help |
Contributor
|
/wait |
Contributor
|
This is actually a proto format error. Did you run |
Contributor
Author
Thanks, I ran |
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Contributor
Author
|
api/envoy/ |
…metrics_service Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
Shikugawa
reviewed
Aug 27, 2021
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
lizan
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaredTan95 jian.tan@daocloud.io
Commit Message: add metrics service config example
Additional Description:
Risk Level:
Testing:
Docs Changes: add metrics service config example