Skip to content

tooling: Tweak tools.base.utils.extract to work with mulitple tarballs (+…#17528

Merged
htuch merged 2 commits intoenvoyproxy:mainfrom
phlax:tooling-untars
Jul 30, 2021
Merged

tooling: Tweak tools.base.utils.extract to work with mulitple tarballs (+…#17528
htuch merged 2 commits intoenvoyproxy:mainfrom
phlax:tooling-untars

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jul 28, 2021

…cleanups)

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: tooling: Tweak utils.base.extract to work with mulitple tarballs (+cleanups)
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax force-pushed the tooling-untars branch 3 times, most recently from 6594749 to f8c1dac Compare July 28, 2021 20:16
…cleanups)

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title tooling: Tweak utils.base.extract to work with mulitple tarballs (+… tooling: Tweak tools.base.utils.extract to work with mulitple tarballs (+… Jul 28, 2021
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits.
/wait

Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 03f2243 into envoyproxy:main Jul 30, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
…lls (+… (envoyproxy#17528)

Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants