router: add dynamic max_stream_duration for upstream #15433
router: add dynamic max_stream_duration for upstream #15433snowp merged 23 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Shikugawa <rei@tetrate.io>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
Shikugawa
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Shikugawa
removed
the
stale
|
@alyssawilk Could you take a look? |
|
mind checking out CI first - looks like there's a tidy failure? |
…4260 Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Shikugawa <rei@tetrate.io>
|
looks like clang tidy may need a look (and unsure if coverage is a flake or not but I'll let you check) |
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Looking good! A few comments from my end, mostly nits :-)
…4260 Signed-off-by: Shikugawa <rei@tetrate.io>
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM modulo one tiny nit.
@snowp would you be willing to do a pass as well?
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks! A few comments, overall this makes sense to me
Signed-off-by: Shikugawa <rei@tetrate.io>
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks, just a few more nits and then I think we're good to go
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
LGTM, deferring to @alyssawilk for final merge
|
looks good modulo the coverage failure. I'll try a re-run but it may need a main merge |
|
Retrying Azure Pipelines: |
…4260 Signed-off-by: Shikugawa <rei@tetrate.io>
|
/retest |
|
Retrying Azure Pipelines: |
|
@alyssawilk Could we merge? |
4 participants
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Close #14260. It adds dynamic
max_stream_durationto configure for upstream request. It works with settingx-envoy-upstream-stream-timeout-msand is prior to set toward static upstreammax_stream_duration.Additional Description:
Risk Level: Low
Testing: Unit / Integration
Docs Changes: Required
Release Notes: Required
Fixes #14260