Skip to content

CI: avoid the legacy Bazel flag name --auth_enabled#17542

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
ulfjack:avoid-legacy-flagname
Jul 30, 2021
Merged

CI: avoid the legacy Bazel flag name --auth_enabled#17542
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
ulfjack:avoid-legacy-flagname

Conversation

@ulfjack
Copy link
Copy Markdown
Contributor

@ulfjack ulfjack commented Jul 29, 2021

Additional Description: Use the much clearer --google_default_credentials
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@repokitteh-read-only
Copy link
Copy Markdown

Hi @ulfjack, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #17542 was opened by ulfjack.

see: more, trace.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Ulf Adams <ulf@engflow.com>
@ulfjack ulfjack force-pushed the avoid-legacy-flagname branch from 17cd5d0 to 0dab476 Compare July 29, 2021 20:14
@lizan lizan self-assigned this Jul 30, 2021
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17542 (review) was submitted by @lizan.

see: more, trace.

@mattklein123 mattklein123 merged commit 2ba5bed into envoyproxy:main Jul 30, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Ulf Adams <ulf@engflow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants