Revert "bazel: update DEPS on googleurl (#17794)"#17958
Merged
junr03 merged 1 commit intoenvoyproxy:mainfrom Sep 2, 2021
Merged
Revert "bazel: update DEPS on googleurl (#17794)"#17958junr03 merged 1 commit intoenvoyproxy:mainfrom
junr03 merged 1 commit intoenvoyproxy:mainfrom
Conversation
This reverts commit c76c951. Signed-off-by: Renjie Tang <renjietang@google.com>
repokitteh-read-only
bot
added
the
deps
wrowe
approved these changes
Sep 2, 2021
Contributor
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
Confirmed identity to https://github.com/envoyproxy/envoy/pull/17957/files - now with DCO
@RenjieTang , @moderation and @junr03 could we please surface an issue to track the discussion #17957 (comment) on the original PR, since it's closed and this one I will close-merged.
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
Member
|
@moderation @wrowe yeah that is something that we have tracked all the way from the project beginning in Envoy Mobile: envoyproxy/envoy-mobile#6. I definitely hear you on the friction. |
mattklein123
added a commit
that referenced
this pull request
Sep 17, 2021
buildbreaker
pushed a commit
to buildbreaker/envoy
that referenced
this pull request
Sep 21, 2021
…nvoyproxy#17958)" This reverts commit 338a42c.
keith
pushed a commit
to keith/envoy
that referenced
this pull request
Sep 29, 2021
…nvoyproxy#17958)" This reverts commit 338a42c. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #17794
This broke Envoy-mobile's Android CI: https://github.com/envoyproxy/envoy-mobile/pull/1776/checks?check_run_id=3487183404#step:7:105
Signed-off-by: Renjie Tang renjietang@google.com