Skip to content

tooling: updating notifier to ping first pass reviewers#17938

Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk:notifier
Sep 1, 2021
Merged

tooling: updating notifier to ping first pass reviewers#17938
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk:notifier

Conversation

@alyssawilk
Copy link
Copy Markdown
Contributor

Risk Level: n/a
Testing: manual
Docs Changes: n/a
Release Notes: n/a

cc @dmitri-d @tonya11en @esmet @KBaichoo @wbpcode @mathetake @RyanTheOptimist so you're not surprised if the bot sends reminders your way :-)

(email filters for to:assign@noreply.github.com helps a lot, but the slackbot nagging is superior)

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@adisuissa
Copy link
Copy Markdown
Contributor

Can you please add me to the first-pass list as well? (my info is in the API_REVIEWERS dict, so should be straight-forward)

@alyssawilk
Copy link
Copy Markdown
Contributor Author

oh yeah, I was thinking you'd be set because API reviews, but those only ping when they need API review. Will do!
you may end up getting dual notifications as the one person in both lists - if it's annoying feel free to send me a PR to dedup :-P

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk merged commit 18cebc7 into envoyproxy:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants