examples: pin version of go-control-plane#17553
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Jul 30, 2021
Merged
Conversation
Signed-off-by: Snow Pettersen <snowp@lyft.com>
phlax
approved these changes
Jul 30, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm, im wondering how we can create a workflow to ensure this is updated reasonably regularly
ggreenway
pushed a commit
to ggreenway/envoy
that referenced
this pull request
Aug 11, 2021
Co-authored-by: Snow Pettersen <snowp@lyft.com> (cherry picked from commit 38b6fd5, PR envoyproxy#17553) Signed-off-by: Greg Greenway <ggreenway@apple.com>
ggreenway
added a commit
that referenced
this pull request
Aug 12, 2021
Re-ordered the operations from how it was done in #17553 to fix an error regarding the `git checkout` would lose local changes to `resource.go`. Changed the pinned version to one from the 1.19 release. Co-authored-by: Snow Pettersen <snowp@lyft.com> (cherry picked from commit 38b6fd5, PR #17553) Signed-off-by: Greg Greenway <ggreenway@apple.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Snow Pettersen <snowp@lyft.com>
RyanTheOptimist
pushed a commit
to RyanTheOptimist/envoy
that referenced
this pull request
Mar 8, 2022
Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: Ryan Hamilton <rch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should disruptive breakages whenever go-control-plane changes its interface.
Signed-off-by: Snow Pettersen snowp@lyft.com
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a