router: remove unused internal redirects member variable#17946
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Sep 3, 2021
Merged
router: remove unused internal redirects member variable#17946mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Derek Argueta <darguetap@gmail.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
junr03
reviewed
Sep 1, 2021
Member
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
lgtm, seems like format is failing?
Member
Author
|
hmm, looks like it keeps failing on I'll try one more kick |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
tyxia
pushed a commit
to tyxia/envoy
that referenced
this pull request
Sep 21, 2021
…17946) Signed-off-by: Derek Argueta <darguetap@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: remove unused internal redirects member variable attempting_internal_redirect_with_complete_stream_.
Additional Description: The code comment that goes with it is also stale.
Risk Level: low
Testing: existing
Docs Changes: n/a
Release Notes: n/a, no functionality change
Platform Specific Features: n/a