CI: Add flag to skip test-result processing#17539
Merged
phlax merged 2 commits intoenvoyproxy:mainfrom Jul 29, 2021
Merged
Conversation
Support flag to skip test processing so that the CI jobs can be re-used for internal builds (which may have their own test-result processing or not want to use the default result-publishing). Signed-off-by: John Murray <murray@stripe.com>
murray-stripe
changed the title
murray-stripe
changed the title
phlax
requested changes
Jul 29, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
could you merge this with the condition below i think it makes for slightly easier reading
otherwise, lgtm
Signed-off-by: John Murray <murray@stripe.com>
Contributor
Author
|
@phlax Thanks for the quick review! I've addressed your feedback. |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
* Add flag to skip test processing Support flag to skip test processing so that the CI jobs can be re-used for internal builds (which may have their own test-result processing or not want to use the default result-publishing). Signed-off-by: John Murray <murray@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Support flag to skip test processing so that the CI jobs can be re-used
for internal builds (which may have their own test-result processing or
not want to use the default result-publishing).
Additional Description: Expand portability of CI scripts
Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]