bazel: update DEPS on googleurl by RenjieTang · Pull Request #17794 · envoyproxy/envoy

RenjieTang · 2021-08-20T20:02:29Z

Commit Message: update DEPS on googleurl
Risk Level: Low
Testing: Current test suites.
Docs Changes: n/a

Signed-off-by: Renjie Tang <renjietang@google.com>

repokitteh-read-only · 2021-08-20T20:02:32Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #17794 was opened by RenjieTang.

see: more, trace.

repokitteh-read-only · 2021-08-20T20:02:34Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #17794 was opened by RenjieTang.

see: more, trace.

RenjieTang · 2021-08-23T16:48:36Z

/assign @wrowe
Hi William, in this PR I added "-Wno-c++11-narrowing" in bazel compile options. It seems that Windows doesn't support it. Do you have any suggestion on this?

moderation · 2021-08-23T18:32:24Z

bazel/repository_locations.bzl

+        # Static snapshot of https://quiche.googlesource.com/quiche/+archive/578e68d9ae4c25e37bc0d23460f3e2f183fe526a.tar.gz.
+        version = "578e68d9ae4c25e37bc0d23460f3e2f183fe526a",
+        sha256 = "dd13bd6732941a2a869e930503daff44c84eabe92788125bebcbe6b1260587c1",
        urls = ["https://storage.googleapis.com/quiche-envoy-integration/googleurl_{version}.tar.gz"],


I was wondering with the recent switch of Quiche deps from quiche.googlesource.com (#17732) I was wondering if this dependency can change too? It doesn't look like the envoy-integration branch is being updated at the Github location - https://github.com/google/quiche/commits/envoy-integration

Yeah I think we can probably move googleurl into Github too. @danzh2010 for more comments.

I chatted with Dan, and it seems that @dio has been in charge of this dep.
I currently need to update this dep to do some URL sanitization work. After this PR, @dio can decide how he wants to proceed with the repo location.

@danzh2010 @RenjieTang @moderation I think we need to move to GitHub, but that needs Google's decision? Since it will be hosted along with https://github.com/google/quiche (or if it is still only all about envoy, judging from the name: "envoy-integration", probably we may host it on envoyproxy org)? cc. @htuch @yanavlasov.

PS. Sorry for the very late reply was out for a long time.

+1 to move to GH like we did for quiche, but let's discuss on the unrevert PR?

wrowe · 2021-08-30T14:34:02Z

Waiting on moving this source to GitHub? Or ready to fly as-is?

wrowe · 2021-08-30T14:38:33Z

bazel/external/googleurl.patch

+@@ -54,3 +54,29 @@ cc_library(
         "//polyfills",
     ] + build_config.icuuc_deps,
 )


Unclear what causes the compilation failure here on windows, I see nothing specific, could you merge main

I think this PR can merge as is, and I will let @dio decide on the repo migration.
Currently the updated googleurl library has -Wno-c++11-narrowing.
Windows CI is throwing "cl : Command line error D8021 : invalid numeric argument '/Wno-c++11-narrowing'"

/wait

This cannot be merged as is, see the bazel/*.bzl logic on how we toggle flags by compiler.

junr03 · 2021-08-30T17:08:28Z

/wait

Signed-off-by: Renjie Tang <renjietang@google.com>

RenjieTang · 2021-09-01T05:10:07Z

/retest

repokitteh-read-only · 2021-09-01T05:10:11Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17794 (comment) was created by @RenjieTang.

see: more, trace.

RenjieTang · 2021-09-01T05:41:41Z

A newer version of googleurl removes the use of -Wno-c++11-narrowing.
I updated the DEPS and this PR should be good to go.

moderation · 2021-09-01T14:24:41Z

/lgtm deps

wrowe

LGTM, that last change to avoid compiler overrides is terrific, ty.

This reverts commit c76c951.

This reverts commit c76c951. Signed-off-by: Renjie Tang <renjietang@google.com>

This reverts commit 338a42c. Signed-off-by: Matt Klein <mklein@lyft.com>

…nvoyproxy#17958)" This reverts commit 338a42c.

…nvoyproxy#17958)" This reverts commit 338a42c. Signed-off-by: Matt Klein <mklein@lyft.com>

update DEPS on googleurl

f2124db

Signed-off-by: Renjie Tang <renjietang@google.com>

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Aug 20, 2021

RenjieTang marked this pull request as ready for review August 23, 2021 16:46

repokitteh-read-only bot assigned wrowe Aug 23, 2021

moderation reviewed Aug 23, 2021

View reviewed changes

wrowe suggested changes Aug 30, 2021

View reviewed changes

repokitteh-read-only bot added the waiting label Aug 30, 2021

try to fix MSVC complier issue

0fd85f5

Signed-off-by: Renjie Tang <renjietang@google.com>

repokitteh-read-only bot removed the waiting label Aug 30, 2021

RenjieTang added 3 commits August 30, 2021 16:48

try to supress msvc 2397 warning

5e81f1f

Signed-off-by: Renjie Tang <renjietang@google.com>

update to a later version

935c892

Signed-off-by: Renjie Tang <renjietang@google.com>

fix some MSVC compiler errors

c13c88e

Signed-off-by: Renjie Tang <renjietang@google.com>

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 1, 2021

wrowe approved these changes Sep 1, 2021

View reviewed changes

wrowe merged commit c76c951 into envoyproxy:main Sep 1, 2021

RenjieTang added a commit to RenjieTang/envoy that referenced this pull request Sep 1, 2021

Revert "bazel: update DEPS on googleurl (envoyproxy#17794)"

bd736cd

This reverts commit c76c951.

RenjieTang mentioned this pull request Sep 1, 2021

Revert "bazel: update DEPS on googleurl" #17957

Closed

RenjieTang added a commit to RenjieTang/envoy that referenced this pull request Sep 2, 2021

Revert "bazel: update DEPS on googleurl (envoyproxy#17794)"

78c0bf7

This reverts commit c76c951. Signed-off-by: Renjie Tang <renjietang@google.com>

RenjieTang mentioned this pull request Sep 2, 2021

Revert "bazel: update DEPS on googleurl (#17794)" #17958

Merged

junr03 pushed a commit that referenced this pull request Sep 2, 2021

Revert "bazel: update DEPS on googleurl (#17794)" (#17958)

338a42c

This reverts commit c76c951. Signed-off-by: Renjie Tang <renjietang@google.com>

mattklein123 added a commit that referenced this pull request Sep 17, 2021

Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)"

95441bb

This reverts commit 338a42c. Signed-off-by: Matt Klein <mklein@lyft.com>

dio mentioned this pull request Sep 17, 2021

Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)" #18167

Closed

buildbreaker pushed a commit to buildbreaker/envoy that referenced this pull request Sep 21, 2021

Revert "Revert "bazel: update DEPS on googleurl (envoyproxy#17794)" (e…

3eb179e

…nvoyproxy#17958)" This reverts commit 338a42c.

buildbreaker mentioned this pull request Sep 24, 2021

Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)" #18192

Closed

keith pushed a commit to keith/envoy that referenced this pull request Sep 29, 2021

Revert "Revert "bazel: update DEPS on googleurl (envoyproxy#17794)" (e…

379ce3f

…nvoyproxy#17958)" This reverts commit 338a42c. Signed-off-by: Matt Klein <mklein@lyft.com>

Conversation

RenjieTang commented Aug 20, 2021

Uh oh!

repokitteh-read-only bot commented Aug 20, 2021

Uh oh!

repokitteh-read-only bot commented Aug 20, 2021

Uh oh!

RenjieTang commented Aug 23, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wrowe commented Aug 30, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

junr03 commented Aug 30, 2021

Uh oh!

RenjieTang commented Sep 1, 2021

Uh oh!

repokitteh-read-only bot commented Sep 1, 2021

Uh oh!

RenjieTang commented Sep 1, 2021

Uh oh!

moderation commented Sep 1, 2021

Uh oh!

wrowe left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants