api: Remove confusing line about auto-generation#17536
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
|
This file is auto generated: envoy/tools/proto_format/proto_format.sh Lines 66 to 68 in 110559f |
is that not for comparison - to check there is no diff ? |
|
one thing im a bit concerned about is that when any api changes its going to expect that header at the top that was removed i kinda meant this pr more as an rfc to try and clarify the situation ill experiment further with api changes |
No, I don't think so. I'm still trying to sort through all of this. It's incredibly confusing and contrib makes it more so. |
…bridge-stream * upstream/main: (140 commits) quiche: remove google quic support (envoyproxy#17465) runtime: removing envoy.reloadable_features.check_ocsp_policy (envoyproxy#17524) upstream: not trying to do HTTP/3 where not configured (envoyproxy#17454) api: Remove confusing line about auto-generation (envoyproxy#17536) v2: removing bootstrap (envoyproxy#17523) connpool: Fix crash in pool removal if the cluster was already deleted (envoyproxy#17522) Enhance the comments clearly (envoyproxy#17517) mysql proxy: connection attributes parsing (envoyproxy#17209) [ci] fix false positive CVE scan from node (envoyproxy#17510) Fixing Envoy Mobile factory strings (envoyproxy#17509) http3: validating codec (envoyproxy#17452) quic: add QUIC upstream stream reset error stats (envoyproxy#17496) thrift proxy: move UpstreamRequest into its own file (envoyproxy#17498) docs: Fixed FaultDelay docs. (envoyproxy#17495) updates links to jaegertracing-plugin.tar.gz (envoyproxy#17497) http: make custom inline headers bootstrap configurable (envoyproxy#17330) deps: update yaml-cpp to latest master (envoyproxy#17489) improving tracer coverage (envoyproxy#17493) Increase buffer size of `Win32RedirectRecords` (envoyproxy#17471) ext_proc: Fix problem with buffered body mode with empty or no body (envoyproxy#17430) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
|
FYI, this line gets re-added for me locally, so, it's going to get re-added in the next commit that changes API I would imagine. |
… there Signed-off-by: Ryan Northey <ryan@synca.io>
|
ive opened a pr to revert #17548 mostly i was trying to demonstrate that while proto_format enforces a format and does a comparison with the docs run in presubmit before proto_format is run, and in postsubmit independently |
|
i guess i can see how it might be regarded as auto-generated my own thinking is that its auto-generated in the way that eg gofmt auto-generates files, altho i guess in this case its formatting from the actual deps, etc i think it comes down to a matter of perspective, personally i edit this file when making related changes, but if you followed a workflow of make changes, run proto_format, then it would be auto-generated really not trying to cause any confusion, just again trying to emphasize that from envoy source proto_format is not part of the pipeline to build anything |
…7548) Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
… there (envoyproxy#17548) Signed-off-by: Ryan Northey <ryan@synca.io>
3 participants
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: api: Remove confusing line about auto-generation
Additional Description:
afaiaa this file is not auto-generated (grepping code appears to confirm that)
i think these messages are present in the api directory so that they are copied over to generated_api_shadow - or perhaps were copied from there at some stage
either way - im pretty sure the message removed here is wrong
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]