thrift proxy: refactor more common functionality#17533
Merged
mattklein123 merged 4 commits intoenvoyproxy:mainfrom Jul 29, 2021
Merged
thrift proxy: refactor more common functionality#17533mattklein123 merged 4 commits intoenvoyproxy:mainfrom
mattklein123 merged 4 commits intoenvoyproxy:mainfrom
Conversation
This is PR 4/5 towards adding shadowing support. This moves the last bits needed to implement shadowing while reusing as much as possible. The next and final PR will be big, but with very few duplicate parts (if any, and they'll be small anyway). Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rgs1
changed the title
added 3 commits
July 29, 2021 10:36
I use these chunks for ShadowRouter implementation. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
I need this, otherwise I'll need to fully implement DecoderFilterCallbacks from the ShadowRouter which is hard because I don't have access to the StreamInfo from there. It would also be a lot of unnecessary boiler plate. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
This is PR 4/5 towards adding shadowing support. This moves the last bits needed to implement shadowing while reusing as much as possible. The next and final PR will be big, but with very few duplicate parts (if any, and they'll be small anyway). Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 4/5 towards adding shadowing support. This moves the last
bits needed to implement shadowing while reusing as much as possible.
The next and final PR will be big, but with very few duplicate
parts (if any, and they'll be small anyway).
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com