tools: actually _notifying_ first pass reviewers#17964
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Sep 3, 2021
Merged
tools: actually _notifying_ first pass reviewers#17964mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
this time actually tested with slackbot token and confirmed with @RyanTheOptimist |
RyanTheOptimist
approved these changes
Sep 2, 2021
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Thanks for doing this!
mattklein123
approved these changes
Sep 3, 2021
tyxia
pushed a commit
to tyxia/envoy
that referenced
this pull request
Sep 21, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: alyssawilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.