mysql proxy: connection attributes parsing #17209
Merged
mattklein123 merged 4 commits intoenvoyproxy:mainfrom Jul 28, 2021
Merged
mysql proxy: connection attributes parsing #17209mattklein123 merged 4 commits intoenvoyproxy:mainfrom
mattklein123 merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: qinggniq <livewithblank@gmail.com>
Contributor
Author
|
@cpakulski PTAL. |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cpakulski
suggested changes
Jul 19, 2021
Contributor
cpakulski
left a comment
cpakulski
left a comment
There was a problem hiding this comment.
Overall looks good.
Some spelling mistakes and tests should avoid so much duplicated code.
source/extensions/filters/network/mysql_proxy/mysql_codec_clogin.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/network/mysql_proxy/mysql_clogin_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: qinggniq <livewithblank@gmail.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
cpakulski
suggested changes
Jul 20, 2021
Contributor
cpakulski
left a comment
cpakulski
left a comment
There was a problem hiding this comment.
The last small comments.
test/extensions/filters/network/mysql_proxy/mysql_clogin_test.cc
Outdated
Show resolved
Hide resolved
| EXPECT_EQ(login_decode.getAuthResp(), login_encode.getAuthResp()); | ||
| EXPECT_EQ(login_decode.getDb(), login_encode.getDb()); | ||
| EXPECT_EQ(login_decode.getAuthPluginName(), login_encode.getAuthPluginName()); | ||
| if (additional_check) { |
Contributor
There was a problem hiding this comment.
Can you compare to nullptr?
test/extensions/filters/network/mysql_proxy/mysql_test_utils.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: qinggniq <livewithblank@gmail.com>
Signed-off-by: qinggniq <livewithblank@gmail.com>
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jul 29, 2021
…bridge-stream * upstream/main: (140 commits) quiche: remove google quic support (envoyproxy#17465) runtime: removing envoy.reloadable_features.check_ocsp_policy (envoyproxy#17524) upstream: not trying to do HTTP/3 where not configured (envoyproxy#17454) api: Remove confusing line about auto-generation (envoyproxy#17536) v2: removing bootstrap (envoyproxy#17523) connpool: Fix crash in pool removal if the cluster was already deleted (envoyproxy#17522) Enhance the comments clearly (envoyproxy#17517) mysql proxy: connection attributes parsing (envoyproxy#17209) [ci] fix false positive CVE scan from node (envoyproxy#17510) Fixing Envoy Mobile factory strings (envoyproxy#17509) http3: validating codec (envoyproxy#17452) quic: add QUIC upstream stream reset error stats (envoyproxy#17496) thrift proxy: move UpstreamRequest into its own file (envoyproxy#17498) docs: Fixed FaultDelay docs. (envoyproxy#17495) updates links to jaegertracing-plugin.tar.gz (envoyproxy#17497) http: make custom inline headers bootstrap configurable (envoyproxy#17330) deps: update yaml-cpp to latest master (envoyproxy#17489) improving tracer coverage (envoyproxy#17493) Increase buffer size of `Win32RedirectRecords` (envoyproxy#17471) ext_proc: Fix problem with buffered body mode with empty or no body (envoyproxy#17430) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: qinggniq <livewithblank@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qinggniq livewithblank@gmail.com
Parse connection attributes when CLIENT_CONNECT_ATTRS is set at the client capability.
Some connector will set connection attributes when connecting. If CLIENT_CONNECT_ATTRS is set but the related field is empty, the server will return bad handshake error.
Commit Message: MySQL proxy codec parsing of connection attributes
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]