tooling: Use upstream distro packages#17843
Conversation
repokitteh-read-only
bot
added
the
deps
phlax
force-pushed
the
tooling-upstream-gpg
branch
7 times, most recently
from
3164901 to
45b1b34
Compare
phlax
changed the title
phlax
changed the title
phlax
changed the title
phlax
force-pushed
the
tooling-upstream-gpg
branch
from
0f1f3ed to
8ec2120
Compare
phlax
changed the title
phlax
force-pushed
the
tooling-upstream-gpg
branch
from
8ec2120 to
88d1198
Compare
phlax
force-pushed
the
tooling-upstream-gpg
branch
from
88d1198 to
6c9ae8e
Compare
phlax
force-pushed
the
tooling-upstream-gpg
branch
6 times, most recently
from
5801528 to
58845b8
Compare
phlax
changed the title
phlax
force-pushed
the
tooling-upstream-gpg
branch
from
58845b8 to
846068e
Compare
tools/base/envoy_python.bzl
Outdated
There was a problem hiding this comment.
@htuch im kinda surprised there isnt anything in rules_ptyhon like this to automatically make a command from a python entrypoint/function etc
either way, i think this is pretty useful and removes a load of boilerplate
There was a problem hiding this comment.
Sorry, what is a command vs. a binary? Are you saying you just want to have a binary with arbitrary entry point?
tools/distribution/BUILD
Outdated
There was a problem hiding this comment.
im wondering if entry_point is a better name for this, i didnt call it that mostly because entry_points arent just for console_scripts - maybe we should call it that
There was a problem hiding this comment.
Yes, please call it entry_point. And also rename to envoy_py_binary with this new support.
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, I'd recommend maybe doing a PR to rules_python to make this a generic supported thing as well? We can land this in Envoy for now with a TODO to cleanup.
tools/base/envoy_python.bzl
Outdated
There was a problem hiding this comment.
Sorry, what is a command vs. a binary? Are you saying you just want to have a binary with arbitrary entry point?
tools/distribution/BUILD
Outdated
There was a problem hiding this comment.
Yes, please call it entry_point. And also rename to envoy_py_binary with this new support.
phlax
force-pushed
the
tooling-upstream-gpg
branch
3 times, most recently
from
6052635 to
583e4fa
Compare
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM once we merge the script PR (just had a documentation nit there and ready to rubber stamp).
phlax
force-pushed
the
tooling-upstream-gpg
branch
from
583e4fa to
ac44836
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
tooling-upstream-gpg
branch
from
ac44836 to
9bdbfc1
Compare
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
2 participants
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: tooling: Use upstream distrotest
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]