Conversation
* also take off useless role button when item is checked out
…Layout for iconclass (#30470) * 🎨 merge two equal JLayouts into one new JLayout * replace hard coded icon to call for JLayout * replace icon mapping to call for JLayout * add icon protected to layout * icon protected moved to jlayout iconclass * remove fas * add icon trash to mapping * add parameter to check if html should be rendered or icon class only * simplify php * replace massive if-then-elseif-then by switch * merge duplicate outcome fa-times * be consistent * simplify switch thx @Quy * copy changes from https://github.com/joomla/joomla-cms/pull/30468/files * copy changes from https://github.com/joomla/joomla-cms/pull/30468/files * remove setting icon to itself * copy changes from #30468 * change to use layout * Update libraries/src/HTML/Helpers/ActionsDropdown.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * use LayoutHelper in function * let default html output be true, instead of false * Update layouts/joomla/icon/iconclass.php I like this PHP7 operator Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Troy T. Hall <programming@hallhome.us> Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Quy <quy@fluxbb.org>
* adding additional check to avoid js script error * fixing js lint error
* [4.0] Modify display and tip for Edit Contact in Frontend * Update administrator/components/com_contact/src/Service/HTML/Icon.php Co-authored-by: Quy <quy@fluxbb.org> * Update Icon.php Co-authored-by: Quy <quy@fluxbb.org>
Aligns icons in mod_login
There is a typo in the Ajax request 'url' parameter.
* re-throw the original exception * re-throw the original exception
[4.0] List Contacts in a Category display
Creating the missing strings in front and backend JCLOSE="Close" JOK="OK" JOPEN="Open" Added the declarations in message.php
* Fix toolbar collapse in mobile view * Match toolbar collapse with cog icon * Removed unused constant
A fieldset should have a legend not a label. There is no visible change its just in the markup which is now valid.
* [4.0] Admin menu redundant link When adjacent links go to the same location this results in additional navigation and repetition for keyboard and screen reader users. WCAG 2.4.4 The parent menu item for Smart Search is the same as the first child menu item. Although the first one is disabled by the js and only acts as means to expand the submenu its still a problem for some assistive technologies. This PR follows the pattern of all other core components and changes the parent link to index.php?option=com_finder This can be tested either by performing a clean installation or by manually applying the sql in the update script. Note that "database fix" will not apply the change in the update script as it is a content change not a structural change. * Update administrator/components/com_admin/sql/updates/mysql/4.0.0-2020-09-19.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Update administrator/components/com_admin/sql/updates/postgresql/4.0.0-2020-09-19.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* [4.0] codestyle fix typo in code comments - code review only required * spelling
Package operations: 0 installs, 38 updates, 0 removals - Updating symfony/deprecation-contracts (v2.1.3 => v2.2.0): Downloading (100%) - Updating joomla/database (2.0.0-beta2 => 2.0.0-beta3): Downloading (100%) - Updating laminas/laminas-zendframework-bridge (1.0.4 => 1.1.1): Downloading (100%) - Updating laminas/laminas-diactoros (2.3.1 => 2.4.1): Downloading (100%) - Updating symfony/string (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/service-contracts (v2.1.3 => v2.2.0): Downloading (100%) - Updating symfony/console (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/var-dumper (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/error-handler (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/options-resolver (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/ldap (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/web-link (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/yaml (v5.1.3 => v5.1.5): Loading from cache - Updating squizlabs/php_codesniffer (3.5.5 => 3.5.6): Loading from cache - Updating symfony/finder (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/event-dispatcher-contracts (v2.1.3 => v2.2.0): Downloading (100%) - Updating symfony/event-dispatcher (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/css-selector (v5.1.3 => v5.1.5): Loading from cache - Updating phpdocumentor/type-resolver (1.3.0 => 1.4.0): Downloading (100%) - Updating phpdocumentor/reflection-docblock (5.2.0 => 5.2.2): Downloading (100%) - Updating codeception/lib-asserts (1.12.0 => 1.13.1): Loading from cache - Updating codeception/codeception (4.1.6 => 4.1.7): Loading from cache - Updating codeception/module-asserts (1.2.1 => 1.3.0): Loading from cache - Updating codeception/module-rest (1.2.1 => 1.2.3): Downloading (100%) - Updating symfony/process (v5.1.3 => v5.1.5): Loading from cache - Updating codeception/module-webdriver (1.1.0 => 1.1.1): Loading from cache - Updating composer/semver (1.5.1 => 1.7.0): Downloading (100%) - Updating composer/xdebug-handler (1.4.2 => 1.4.3): Loading from cache - Updating doctrine/annotations (1.10.3 => 1.10.4): Loading from cache - Updating symfony/filesystem (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/stopwatch (v5.1.3 => v5.1.5): Loading from cache - Updating joomla/filesystem (1.5.2 => 1.6.0): Loading from cache - Updating composer/ca-bundle (1.2.7 => 1.2.8): Loading from cache - Updating nyholm/psr7 (1.3.0 => 1.3.1): Downloading (100%) - Updating spomky-labs/base64url (v2.0.2 => v2.0.3): Loading from cache - Updating symfony/dom-crawler (v5.1.3 => v5.1.5): Loading from cache - Updating symfony/browser-kit (v5.1.3 => v5.1.5): Loading from cache - Updating brick/math (0.8.15 => 0.8.17): Loading from cache ### note Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
* Renaming the "default" chrome to "card" as it isn't a default chrome at all. * There is no "xhtml" chrome anymore
* Fix saving images * Typo * CS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required