Skip to content

In Joomla 4 - Rename Control Panel as Home Dashboard#30673

Merged
wilsonge merged 5 commits intojoomla:4.0-devfrom
ceford:cpanel
Sep 18, 2020
Merged

In Joomla 4 - Rename Control Panel as Home Dashboard#30673
wilsonge merged 5 commits intojoomla:4.0-devfrom
ceford:cpanel

Conversation

@ceford
Copy link
Contributor

@ceford ceford commented Sep 18, 2020

Pull Request for Issue #29477 .

Summary of Changes

All of the Dashboards in Joomla 4 have xxx Dashboard in the Title bar, except the page linked to by the Home Dashboard menu item, which is entitled Control Panel. This pull request simply changes the page title from Control Panel to Home Dashboard. There are 11 occurrences of "Home Dashboard" and 8 occurrences of "Control Panel". After applying this pull request there is 1 occurrence of "control panel" which refers to the hosting control panel.

Testing Instructions

Select Home Dashboard from the Administrator menu.

Actual result BEFORE applying this Pull Request

The page title is Control Panel

Expected result AFTER applying this Pull Request

The page title is Home Dashboard

Documentation Changes Required

The Help screen changes are in hand - that is where this anomaly came to light. There are likely to be other mentions of Control Panel in Tutorials.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 18, 2020
@ceford
Copy link
Contributor Author

ceford commented Sep 18, 2020

I do not understand why there are conflicts. The two files concerned just have Home Dashboard in place of Control Panel in translation strings. Could someone explain?

@brianteeman
Copy link
Contributor

The problem most likely is that your own branch was not completely up to date

@infograf768
Copy link
Member

I have some difficulties accepting to rename the cpanel component as Home Dashboard component...
Changing the Control Panel title page to Home dashboard may be fine, but the component IS cpanel.

@ceford
Copy link
Contributor Author

ceford commented Sep 18, 2020

I have some difficulties accepting to rename the cpanel component as Home Dashboard component...
Changing the Control Panel title page to Home dashboard may be fine, but the component IS cpanel.

I thought about that and don't disagree. However, I think the only place the component is referred to by name is in the Extensions: Manage page. If you select by Status=Protected and Type=Component you will see Articles in the list. But there is no Articles component. And there are several more names that do not correspond to components.

@brianteeman
Copy link
Contributor

Changing the Control Panel title page to Home dashboard may be fine, but the component IS cpanel.

So what. The component is com_content but we call it articles

Just another spurious reason to block any change when it might create some work for a translator

@wilsonge wilsonge merged commit 0749c5f into joomla:4.0-dev Sep 18, 2020
@wilsonge
Copy link
Contributor

This seems much more logical to me to make our naming consistent across the backend

@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 18, 2020
@ceford
Copy link
Contributor Author

ceford commented Sep 18, 2020

Thanks guys. I will try to get it right first time in future.

@richard67
Copy link
Member

@wilsonge System tests in the 4.0-dev branch are consistently failing now, and I think it could be related to this PR. After the installation, the test browser simulation seems not to find the statistics alert to close it, This could be due to changed page title. See screenshot of the test: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30680/system-tests/35473/InstallCest.configureJoomla.mysql.fail.png

@richard67
Copy link
Member

@wilsonge I am right: See file ./libraries/vendor/joomla-projects/joomla-browser/src/Locators/Locators.php line 138:
public $adminControlPanelText = 'Control Panel';.

Does this have to be fixed upstream?

@richard67
Copy link
Member

@ceford For you as explanation: The "joomla-browser" is a tool which we use for running system tests. It still assumes that the page title of the Home Dasboard is "Control Panel", and so the system test can't find the statistics alert to be closed after installation. So the system test fails at this point.

@wilsonge
Copy link
Contributor

Thanks for flagging @richard67 . Hopefully c41e9bf should be the fix. Just watching the tests run through now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants