[4.0] Get categories from component#30613
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Sep 12, 2020
SharkyKZ:j4/cleanup/field-categories
Merged
[4.0] Get categories from component#30613wilsonge merged 2 commits intojoomla:4.0-devfrom SharkyKZ:j4/cleanup/field-categories
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/cleanup/field-categories
Conversation
|
I have tested this item ✅ successfully on 827a8d5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30613. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 827a8d5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30613. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30613. |
Contributor
|
Will this still work on J3 style components that don't use services? |
Contributor
Author
|
It should. Legacy components implement joomla-cms/libraries/src/Extension/LegacyComponent.php Lines 37 to 40 in a5cd87a Works with Weblinks 3.7.0. |
Contributor
|
Cool - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26157 (comment).
Summary of Changes
Get categories from component instead of using deprecated
JCategories::getInstance().Testing Instructions
Create a custom field for articles.
Assign to
Uncategorisedcategory.Create an article. Select
Uncategorisedcategory.Check that custom field appears in form.
Expected result AFTER applying this Pull Request
Works like before.
Documentation Changes Required
No.