[4.0] Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options#30629
Merged
Quy merged 1 commit intojoomla:4.0-devfrom Sep 13, 2020
Conversation
Contributor
|
It works as you say, so tested successfully. In my opinion it is always an error to have switches with another label than yes/no or show/hide. But this is not in scope of tihs PR. |
Contributor
|
I have tested this item ✅ successfully on c27e6fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629. |
1 similar comment
|
I have tested this item ✅ successfully on c27e6fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629. |
Contributor
|
I have tested this item ✅ successfully on c27e6fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629. |
Contributor
|
Thanks. |
Member
Author
|
Thanks too. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Change order of options of the "Fluid Layout" toggle in Cassiopeia's template style options so it is like for other toggle buttons.
Testing Instructions
Check in the template style's advanced options of Cassiopeia how the toggle buttons are coloured when being not enabled and when being enabled.
Actual result BEFORE applying this Pull Request
When not enabled, "Fluid Layout" is coloured green (see red mark in screenshot below), while other toggles are grey when not being enabled (see green mark below):

When enabled, "Fluid Layout" is coloured grey (see red mark in screenshot below), while other toggles are green when being enabled (see green mark below):

Expected result AFTER applying this Pull Request
Grey when "Fluid Layout" is not enabled, i.e. static layout is used:

Green when "Fluid Layout" is enabled:

Documentation Changes Required
None.