Skip to content

[4.0] Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options#30629

Merged
Quy merged 1 commit intojoomla:4.0-devfrom
richard67:4.0-dev-fix-cassiopeia-template-style-fluid-toggle-colors
Sep 13, 2020
Merged

[4.0] Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options#30629
Quy merged 1 commit intojoomla:4.0-devfrom
richard67:4.0-dev-fix-cassiopeia-template-style-fluid-toggle-colors

Conversation

@richard67
Copy link
Member

Pull Request for Issue # .

Summary of Changes

Change order of options of the "Fluid Layout" toggle in Cassiopeia's template style options so it is like for other toggle buttons.

Testing Instructions

Check in the template style's advanced options of Cassiopeia how the toggle buttons are coloured when being not enabled and when being enabled.

Actual result BEFORE applying this Pull Request

When not enabled, "Fluid Layout" is coloured green (see red mark in screenshot below), while other toggles are grey when not being enabled (see green mark below):
j4-cassiopeia-fluid_1

When enabled, "Fluid Layout" is coloured grey (see red mark in screenshot below), while other toggles are green when being enabled (see green mark below):
j4-cassiopeia-fluid_2

Expected result AFTER applying this Pull Request

Grey when "Fluid Layout" is not enabled, i.e. static layout is used:
j4-cassiopeia-fluid_3

Green when "Fluid Layout" is enabled:
j4-cassiopeia-fluid_4

Documentation Changes Required

None.

@richard67 richard67 changed the title Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options [4.0] Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options Sep 13, 2020
@chmst
Copy link
Contributor

chmst commented Sep 13, 2020

It works as you say, so tested successfully.

In my opinion it is always an error to have switches with another label than yes/no or show/hide. But this is not in scope of tihs PR.

@chmst
Copy link
Contributor

chmst commented Sep 13, 2020

I have tested this item ✅ successfully on c27e6fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on c27e6fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 13, 2020
@hans2103
Copy link
Contributor

I have tested this item ✅ successfully on c27e6fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

@Quy Quy added this to the Joomla 4.0 milestone Sep 13, 2020
@Quy Quy merged commit 0e5b6cf into joomla:4.0-dev Sep 13, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 13, 2020
@Quy
Copy link
Contributor

Quy commented Sep 13, 2020

Thanks.

@richard67
Copy link
Member Author

Thanks too.

@richard67 richard67 deleted the 4.0-dev-fix-cassiopeia-template-style-fluid-toggle-colors branch September 13, 2020 15:06
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants