[4.0] save group button hover fix#30618
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Sep 12, 2020
Merged
Conversation
joomla-cms-bot
added
NPM Resource Changed
ruchikanagarkar
changed the title
Contributor
|
In list view, it should be blue.
|
sandewt
reviewed
Sep 12, 2020
| .btn-group.show .dropdown-menu &:not(.disabled) { | ||
| color: var(--atum-text-light); | ||
| background-color: var(--atum-bg-dark); | ||
| background-color: theme-color("success");; |
Contributor
There was a problem hiding this comment.
background-color: theme-color("success");;
should be: remove semicolon ( ; )
background-color: theme-color("success");
Contributor
|
I have tested this item ✅ successfully on 0a7151a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30618. |
Contributor
|
I have tested this item ✅ successfully on 0a7151a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30618. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30618. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .#30116
Summary of Changes
Modified the theme color for save group buttons
Testing Instructions
Joomla 4 -> create article -> click on save & close dropdown -> hover the dropdown save options it must show green background color.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No