[4.0] Missing alerts strings#30684
Merged
richard67 merged 2 commits intojoomla:4.0-devfrom Sep 19, 2020
Merged
Conversation
Bakual
reviewed
Sep 19, 2020
|
I have tested this item ✅ successfully on d05869c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30684. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on d05869c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30684. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30684. |
Member
|
Thanks! |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Creating the missing strings in front and backend JCLOSE="Close" JOK="OK" JOPEN="Open" Added the declarations in message.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30682
Summary of Changes
Creating the missing strings in front and backend
JCLOSE="Close"
JOK="OK"
JOPEN="Open"
Added the declarations in message.php
The strings are present in
/media/vendor/joomla-custom-elements/js/joomla-alert-es5.jsTesting Instructions
Save an article and look at the markup produced for the X icon closing the alert.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required