[4.0] Adding back string deleted by error in 30588#30601
Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom Sep 11, 2020
Merged
[4.0] Adding back string deleted by error in 30588#30601HLeithner merged 2 commits intojoomla:4.0-devfrom
HLeithner merged 2 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on abf6dae This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601. |
Contributor
Oops, what should I pay attention to when testing? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601. |
Member
Author
Nothing. It is just a useless role which was taken off from the original patch for published/unpublished and was forgotten from the part concerning checked out status. |
Contributor
|
I have tested this item ✅ successfully on abf6dae This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601. |
Member
|
Thanks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* also take off useless role button when item is checked out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The string
COM_CONTENT_EDIT_ITEM="Edit Article"was deleted in #30588 by error.It is used when Displaying a Category list.
EDIT : Also role=button is useless when article is checked out
Testing Instructions
Create a Category List menu item. Log as superuser in frontend and display that menu item
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request