Skip to content

[4.0] Adding back string deleted by error in 30588#30601

Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom
infograf768:4.0_missing_lang_string
Sep 11, 2020
Merged

[4.0] Adding back string deleted by error in 30588#30601
HLeithner merged 2 commits intojoomla:4.0-devfrom
infograf768:4.0_missing_lang_string

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Sep 9, 2020

Summary of Changes

The string COM_CONTENT_EDIT_ITEM="Edit Article" was deleted in #30588 by error.
It is used when Displaying a Category list.

EDIT : Also role=button is useless when article is checked out

Testing Instructions

Create a Category List menu item. Log as superuser in frontend and display that menu item

Actual result BEFORE applying this Pull Request

Screen Shot 2020-09-09 at 10 26 01

Expected result AFTER applying this Pull Request

Screen Shot 2020-09-09 at 10 27 24

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 9, 2020
@sandewt
Copy link
Contributor

sandewt commented Sep 9, 2020

I have tested this item ✅ successfully on abf6dae

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601.

@sandewt
Copy link
Contributor

sandewt commented Sep 9, 2020

EDIT : Also role=button is useless when article is checked out

Oops, what should I pay attention to when testing?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601.

@infograf768
Copy link
Member Author

Oops, what should I pay attention to when testing?

Nothing. It is just a useless role which was taken off from the original patch for published/unpublished and was forgotten from the part concerning checked out status.

@Quy
Copy link
Contributor

Quy commented Sep 9, 2020

I have tested this item ✅ successfully on abf6dae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601.

@Quy
Copy link
Contributor

Quy commented Sep 9, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30601.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 9, 2020
@HLeithner HLeithner merged commit b04a399 into joomla:4.0-dev Sep 11, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 11, 2020
@infograf768 infograf768 deleted the 4.0_missing_lang_string branch September 11, 2020 06:35
@zero-24 zero-24 added this to the Joomla 4.0 milestone Sep 11, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* also take off useless role button when item is checked out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants