Skip to content

[4.0] Modify display and tip for Edit Contact in Frontend#30605

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
infograf768:4.0_edit_contact_frontend
Sep 12, 2020
Merged

[4.0] Modify display and tip for Edit Contact in Frontend#30605
wilsonge merged 3 commits intojoomla:4.0-devfrom
infograf768:4.0_edit_contact_frontend

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Sep 9, 2020

Summary of Changes

This patch is similar to #30588 which was dealing with article edit.

We do not need the Cog and dropdown as there is only one choice.

Includes some small temporary changes for List Contact Category. This will anyway be taken care of by the Cassiopea Team

Testing Instructions

3 situations:

1. Edit Contact when contact published // simplified tip
2. Edit Contact when contact is unpublished // simplified tip
3. Contact is checked out by another user

Patch, run npm ci

Expected result AFTER applying this Pull Request

Screen Shot 2020-09-09 at 16 26 32

Screen Shot 2020-09-09 at 17 01 36

Screen Shot 2020-09-09 at 12 51 53

publiswhed contact

@infograf768 infograf768 added the a11y Accessibility label Sep 9, 2020
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 9, 2020
@wilsonge wilsonge merged commit 6945d72 into joomla:4.0-dev Sep 12, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 12, 2020
@infograf768 infograf768 deleted the 4.0_edit_contact_frontend branch September 12, 2020 11:12
@infograf768
Copy link
Member Author

Thanks. Will now make pr for rge listcategory display

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* [4.0] Modify display and tip for Edit Contact in Frontend

* Update administrator/components/com_contact/src/Service/HTML/Icon.php

Co-authored-by: Quy <quy@fluxbb.org>

* Update Icon.php

Co-authored-by: Quy <quy@fluxbb.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants