Skip to content

[4.0] Store memory and time as float in Profiler#30574

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/php8/profiler
Sep 15, 2020
Merged

[4.0] Store memory and time as float in Profiler#30574
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/php8/profiler

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Sep 5, 2020

Pull Request for Issue # .

Summary of Changes

Changes mark memory and time format from improperly formatted string to float.

Testing Instructions

Enable debug on PHP 8.

Actual result BEFORE applying this Pull Request

abs(): Argument #1 ($number) must be of type int|float, string given

Expected result AFTER applying this Pull Request

No errors.

Documentation Changes Required

Maybe?

Additional Comments

We also need something like this for staging (can be done without changing data type), waiting for response in #29353.

@alikon
Copy link
Contributor

alikon commented Sep 10, 2020

I have tested this item ✅ successfully on 5501f71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30574.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 5501f71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30574.

@Quy
Copy link
Contributor

Quy commented Sep 13, 2020

RTC

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 13, 2020
@Quy Quy added the PR-4.0-dev label Sep 13, 2020
@wilsonge wilsonge merged commit a1d94c4 into joomla:4.0-dev Sep 15, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 15, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 15, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants