[4.0] adding additional check to avoid js script error#30593
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Sep 11, 2020
Merged
[4.0] adding additional check to avoid js script error#30593wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
I have tested this item ✅ successfully on 6e8dd5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30593. |
pdkpavankumar
changed the title
Contributor
|
Thanks! |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* adding additional check to avoid js script error * fixing js lint error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # . #29157
Summary of Changes
added additional check in js file to avoid script error
Testing Instructions
Actual result BEFORE applying this Pull Request
TypeError: c.querySelector(...) is null -- rotate.min.js:1:1416Expected result AFTER applying this Pull Request
No script error should come and functionality should work as is.
Documentation Changes Required
NO