[4.0] more elements hard coded to string#30720
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Sep 21, 2020
Merged
Conversation
joomla-cms-bot
added
Language Change
Contributor
|
Merged on review. Thanks |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue ##30708 .
Summary of Changes
Change hard coded string in the JS to a translatable constant
Testing Instructions
Apply pr and npm ci
Reduce screen size until we have an ellipsis to dropdown the elements that don't fit anymore in Header.
It still says "More Elements" on hover etc
Note
I am not convinced about the text but unless there are other suggestions its ok
Documentation Changes Required
none